Retry check of service IP configured #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are scenarios where the config-changed hook can complete, yet the service IP get configured many seconds after, because a relation-changed hook execution needs to be triggered on the hacluster side of the relation. This change adds a retry to the check (10 times with a 2 seconds wait time). This issue was found at the gate https://review.opendev.org/c/openstack/charm-designate-bind/+/861417
|
This PR is being exercised by this patch - https://review.opendev.org/c/openstack/charm-designate-bind/+/862735 |
openstack-mirroring
pushed a commit
to openstack/charm-designate-bind
that referenced
this pull request
Oct 28, 2022
- mysql-innodb-cluster - rabbitmq-server Change-Id: I1a009cd083a22ba86ba2fd4aec660d7729a283f7 Func-Test-Pr: openstack-charmers/zaza-openstack-tests#970
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Oct 28, 2022
* Update charm-designate-bind from branch 'master'
to 490a302815fea29601e42ea4e5e4f38a70034d0c
- Drop 'source' config key from support charms
- mysql-innodb-cluster
- rabbitmq-server
Change-Id: I1a009cd083a22ba86ba2fd4aec660d7729a283f7
Func-Test-Pr: openstack-charmers/zaza-openstack-tests#970
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are scenarios where the config-changed hook can complete, yet the service IP get configured many seconds after, because a relation-changed hook execution needs to be triggered on the hacluster side of the relation.
This change adds a retry to the check (10 times with a 2 seconds wait time).
This issue was found at the gate https://review.opendev.org/c/openstack/charm-designate-bind/+/861417