Add force and max_wait parameters to destroy_model() #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For tests we need to make sure the model is destroyed, and that means provided force to it. We also want to only wait about 10 minutes. Finally, we want to make sure that the model is actually destroyed. If not, we'll bail out as something rather drastic has gone wrong.
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
==========================================
+ Coverage 82.16% 82.18% +0.01%
==========================================
Files 29 29
Lines 2277 2284 +7
==========================================
+ Hits 1871 1877 +6
- Misses 406 407 +1
Continue to review full report at Codecov.
|
lourot
approved these changes
Jan 20, 2021
It turns out that the juju destroy_model() function returns before the model has dissapeared from .list_models(). It can also still be seen in the juju status after the function has returned. Async issues, I suspect. Anyway, this commit adds a retry to provide time for the deleted model to disappear, and thus (hopefully) all the resources to be cleaned up.
openstack-mirroring
pushed a commit
to openstack/charm-percona-cluster
that referenced
this pull request
Jan 21, 2021
Includes updates to charmhelpers/charms.openstack for cert_utils and unit-get for the install hook error on Juju 2.9 * charm-helpers sync for classic charms * rebuild for reactive charms * ensure tox.ini is from release-tools * ensure requirements.txt files are from release-tools * On reactive charms: - ensure master branch for charms.openstack - ensure master branch for charm-helpers * Include NoNetworkBinding late fix. func-test-pr: openstack-charmers/zaza#409 Change-Id: I1a97004410c5cf4ef98164281137bce46756b12c
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Jan 21, 2021
* Update charm-percona-cluster from branch 'master'
to af9c467e353ca8e9254809f8f289fc383284da5e
- Updates for testing period for 20.01 release
Includes updates to charmhelpers/charms.openstack for cert_utils
and unit-get for the install hook error on Juju 2.9
* charm-helpers sync for classic charms
* rebuild for reactive charms
* ensure tox.ini is from release-tools
* ensure requirements.txt files are from release-tools
* On reactive charms:
- ensure master branch for charms.openstack
- ensure master branch for charm-helpers
* Include NoNetworkBinding late fix.
func-test-pr: openstack-charmers/zaza#409
Change-Id: I1a97004410c5cf4ef98164281137bce46756b12c
ChrisMacNaughton
approved these changes
Jan 21, 2021
coreycb
pushed a commit
to coreycb/zaza
that referenced
this pull request
Oct 17, 2023
…rot/rabbitmq-910-pause-resume Make RmqTests.test_910_pause_and_resume more robust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tests we need to make sure the model is destroyed, and that means
provided force to it. We also want to only wait about 10 minutes.
Finally, we want to make sure that the model is actually destroyed. If
not, we'll bail out as something rather drastic has gone wrong.