Reap instances on openstack provider and destroy storage #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a sequence of bundles (e.g. for func) creates storage, if destroy_storage is not used, then the model (possibly) leaves the storage behind. This patch enables the destroy_storage feature in destroy_model() call in python_libjuju.
Codecov Report
@@ Coverage Diff @@
## master #411 +/- ##
=======================================
Coverage 82.20% 82.20%
=======================================
Files 29 29
Lines 2287 2287
=======================================
Hits 1880 1880
Misses 407 407
Continue to review full report at Codecov.
|
Essentially, the destroy-model with --force (via libjuju) doesn't reap the instances leading to CI failures if multiple bundles are used as it relies on proper clean-up of the instances and their vips. This patch uses the undercloud OpenStack directly to remove the instances that used to belong to the model that was just destroyed. Only has an affect on the openstack provider.
ajkavanagh
changed the title
openstack-mirroring
pushed a commit
to openstack/charm-masakari
that referenced
this pull request
Jan 29, 2021
Includes updates to charmhelpers/charms.openstack for cert_utils and unit-get for the install hook error on Juju 2.9 * charm-helpers sync for classic charms * rebuild for reactive charms * ensure tox.ini is from release-tools * ensure requirements.txt files are from release-tools * On reactive charms: - ensure master branch for charms.openstack - ensure master branch for charm-helpers The func test pr is to test/verify the reap instances change in zaza. func-test-pr: openstack-charmers/zaza#411 Change-Id: I744bd6f88c88ef30754bcf947c5379334b24631a
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Jan 29, 2021
* Update charm-masakari from branch 'master'
to 74a2bc949cff379b2c2427af052468fe43144b51
- Updates for testing period for 20.01 release
Includes updates to charmhelpers/charms.openstack for cert_utils
and unit-get for the install hook error on Juju 2.9
* charm-helpers sync for classic charms
* rebuild for reactive charms
* ensure tox.ini is from release-tools
* ensure requirements.txt files are from release-tools
* On reactive charms:
- ensure master branch for charms.openstack
- ensure master branch for charm-helpers
The func test pr is to test/verify the reap instances change in zaza.
func-test-pr: openstack-charmers/zaza#411
Change-Id: I744bd6f88c88ef30754bcf947c5379334b24631a
lourot
approved these changes
Jan 29, 2021
|
Travis seems not to pick the last change up, but since it's minor and the previous commit was validating, I'm landing this, thanks! |
coreycb
pushed a commit
to coreycb/zaza
that referenced
this pull request
Oct 17, 2023
…-octavia-tempest Add Octavia to Tempest service list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a sequence of bundles (e.g. for func) creates storage, if
destroy_storage is not used, then the model (possibly) leaves the
storage behind. This patch enables the destroy_storage feature in
destroy_model() call in python_libjuju.