Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more info when DestroyModelFailed #424

Merged
merged 1 commit into from Feb 19, 2021
Merged

Add more info when DestroyModelFailed #424

merged 1 commit into from Feb 19, 2021

Conversation

lourot
Copy link
Contributor

@lourot lourot commented Feb 19, 2021

Add info about remaining applications and machines
to the exception.

I have seen this exception twice recently in this gerrit change. I suspect we could increase the timeout but I'd like to understand it better first. The new exception text will look like this:

Traceback (most recent call last):
  File "/home/ubuntu/Documents/git/manila/build/builds/manila/.tox/func/lib/python3.8/site-packages/zaza/controller.py", line 83, in async_destroy_model
    raise zaza.utilities.exceptions.DestroyModelFailed(error_msg)
zaza.utilities.exceptions.DestroyModelFailed: Destroying model zaza-1e98b395e9dc failed. Remaining apps: hacluster, rabbitmq-server, manila, percona-cluster, manila-generic, keystone. 6 remaining machine(s).

@lourot
Add more info when DestroyModelFailed
6ecef81 
Add info about remaining applications and machines
to the exception.
ajkavanagh
ajkavanagh approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@ajkavanagh ajkavanagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajkavanagh ajkavanagh merged commit e9ae122 into master Feb 19, 2021
@lourot lourot deleted the lourot/destroymodelfailed branch February 20, 2021 10:09
openstack-mirroring pushed a commit to openstack/charm-manila that referenced this pull request Feb 20, 2021
@wolsen @lourot
Ensure that endpoints are updated when tls config changes
9f22f1d 
When tls settings change, the endpoints need to be updated on the
identity-service relation in order for keystone to update the service
catalog with the new endpoints. This change follows the behavior of
other reactive charms and performs this update within the handlers
code.

Func-Test-Pr: openstack-charmers/zaza#424
Change-Id: I201fc382f044111e6f28a13c64a55e2f79c1d6aa
Closes-Bug: #1901589
openstack-mirroring pushed a commit to openstack/openstack that referenced this pull request Feb 20, 2021
@wolsen @openstack-gerrit
Update git submodules
b0fda89 
* Update charm-manila from branch 'master'
  to 9f22f1d0dd0f3a07bd2b70270542b1c8aa946e17
  - Ensure that endpoints are updated when tls config changes
    
    When tls settings change, the endpoints need to be updated on the
    identity-service relation in order for keystone to update the service
    catalog with the new endpoints. This change follows the behavior of
    other reactive charms and performs this update within the handlers
    code.
    
    Func-Test-Pr: openstack-charmers/zaza#424
    Change-Id: I201fc382f044111e6f28a13c64a55e2f79c1d6aa
    Closes-Bug: #1901589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajkavanagh ajkavanagh ajkavanagh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lourot @ajkavanagh