Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture enough lines for troubleshooting #518

Merged

Conversation

nobuto-m
Copy link
Contributor

Follow-up of 9159cf5

20 lines are not enough sometimes to capture the real error or failure.
By having 200 lines we can cover most of the output from a single hook
execution. For example, the real DNS failure wasn't captured in Zaza
output but the full juju crashdump had to be downloaded to see those
lines.

unit.mysql-innodb-cluster/2.install logger.go:60 W: Failed to fetch
http://archive.ubuntu.com/ubuntu/dists/focal/InRelease Temporary failure
resolving 'archive.ubuntu.com'
unit.mysql-innodb-cluster/2.install logger.go:60
subprocess.CalledProcessError: Command '['apt-get',
'--option=Dpkg::Options::=--force-confold', '--assume-yes', 'install',
'python3-pip', 'python3-setuptools', 'python3-yaml', 'python3-dev',
'python3-wheel', 'build-essential']' returned non-zero exit status 100.

Follow-up of 9159cf5

20 lines are not enough sometimes to capture the real error or failure.
By having 200 lines we can cover most of the output from a single hook
execution. For example, the real DNS failure wasn't captured in Zaza
output but the full juju crashdump had to be downloaded to see those
lines.

unit.mysql-innodb-cluster/2.install logger.go:60 W: Failed to fetch
http://archive.ubuntu.com/ubuntu/dists/focal/InRelease Temporary failure
resolving 'archive.ubuntu.com'

unit.mysql-innodb-cluster/2.install logger.go:60
subprocess.CalledProcessError: Command '['apt-get',
'--option=Dpkg::Options::=--force-confold', '--assume-yes', 'install',
'python3-pip', 'python3-setuptools', 'python3-yaml', 'python3-dev',
'python3-wheel', 'build-essential']' returned non-zero exit status 100.
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #518 (b6a5ab7) into master (1ec92a9) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #518   +/-   ##
=======================================
  Coverage   89.00%   89.00%           
=======================================
  Files          44       44           
  Lines        4429     4429           
=======================================
  Hits         3942     3942           
  Misses        487      487           
Impacted Files Coverage Δ
zaza/charm_lifecycle/func_test_runner.py 72.83% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ec92a9...b6a5ab7. Read the comment docs.

@nobuto-m
Copy link
Contributor Author

Python package / func (pull_request) Failing after 1m — func

+ sudo snap install --classic juju
error: cannot perform the following tasks:
- Download snap "core18" (2409) from channel "stable" (received an unexpected http response code (503) when trying to download https://canonical-bos01.cdn.snapcraftcontent.com/download-origin/canonical-lgw01/CSO04Jhav2yK0uz97cr0ipQRyqg0qQL6_2409.snap?interactive=1&token=

A hiccup of the networking infrastructure I believe.

Copy link
Contributor

@ajkavanagh ajkavanagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; the codecov warning, whilst annoying, means this function was never covered by tests; I don't think it's appropriate to ask for the test for this change.

@ajkavanagh ajkavanagh merged commit 856cf7e into openstack-charmers:master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants