Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (async_)block_until_charm_channel support #619

Merged

Conversation

coreycb
Copy link

@coreycb coreycb commented Oct 17, 2023

This adds async_block_until_charm_channel and
block_until_charm_channel which will initially be
used for charm upgrade testing.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
zaza/model.py 87.16% <100.00%> (+0.09%) ⬆️

📢 Thoughts on this report? Let us know!.

This adds async_block_until_charm_channel and
block_until_charm_channel which will initially be
used for charm upgrade testing.
@coreycb coreycb marked this pull request as ready for review October 25, 2023 19:32
@coreycb
Copy link
Author

coreycb commented Oct 25, 2023

This change will be used by the charmed-openstack-tester changes in openstack-charmers/charmed-openstack-tester#123

Copy link
Contributor

@ajkavanagh ajkavanagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice; I really like the use of ro_types to create the test object that has a .charm_channel accessor. Very clever!

@ajkavanagh ajkavanagh merged commit ff396eb into openstack-charmers:master Oct 26, 2023
8 checks passed
openstack-mirroring pushed a commit to openstack/charm-swift-storage that referenced this pull request Oct 26, 2023
Sync charm-helpers to pick up fix for openstack_upgrade_available
that enables successful payload upgrades. This will need backporting
to stable/wallaby.

openstack-charmers/zaza#619
Closes-Bug: #2040606
Change-Id: Ib1586a486a7a01023bd59bfa70016481ad5f89dc
openstack-mirroring pushed a commit to openstack/openstack that referenced this pull request Oct 26, 2023
* Update charm-swift-storage from branch 'master'
  to ca420eccbb9e1cd51379b27ac684ef6e94d380e7
  - Enable swift payload upgrades for wallaby+
    
    Sync charm-helpers to pick up fix for openstack_upgrade_available
    that enables successful payload upgrades. This will need backporting
    to stable/wallaby.
    
    openstack-charmers/zaza#619
    Closes-Bug: #2040606
    Change-Id: Ib1586a486a7a01023bd59bfa70016481ad5f89dc
openstack-mirroring pushed a commit to openstack/charm-swift-proxy that referenced this pull request Oct 26, 2023
Sync charm-helpers to pick up fix for openstack_upgrade_available
that enables successful payload upgrades. This will need backporting
to stable/wallaby.

openstack-charmers/zaza#619
Closes-Bug: #2040606
Change-Id: Ib5f446d617c11c9c9046c33335c1099b21b5166e
openstack-mirroring pushed a commit to openstack/openstack that referenced this pull request Oct 26, 2023
* Update charm-swift-proxy from branch 'master'
  to 4ebb43d731da8a048e1ac7cc9fc8b33468cb7e76
  - Enable swift payload upgrades for wallaby+
    
    Sync charm-helpers to pick up fix for openstack_upgrade_available
    that enables successful payload upgrades. This will need backporting
    to stable/wallaby.
    
    openstack-charmers/zaza#619
    Closes-Bug: #2040606
    Change-Id: Ib5f446d617c11c9c9046c33335c1099b21b5166e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants