Skip to content
This repository has been archived by the owner on Aug 1, 2019. It is now read-only.

Commit

Permalink
Buck: Simplify build rules
Browse files Browse the repository at this point in the history 
Since [1] dependencies to targets used in $(location //path/to:target)
macro are added implicitly.

This can be verified by using Bucks audit and targets commands:

  $ buck targets --json api
  [...]
  "buck.type" : "genrule",
  "name" : "api",
  "deps" : [ ],
  [...]

So explicit dependencies are empty, but implicit dependencies are still
present:

  $ buck audit dependencies api
  //gerrit-extension-api:extension-api
  //gerrit-extension-api:extension-api-javadoc
  //gerrit-extension-api:extension-api-src
  //gerrit-plugin-api:plugin-api
  //gerrit-plugin-api:plugin-api-javadoc
  //gerrit-plugin-api:plugin-api-src
  //gerrit-plugin-gwtui:gwtui-api
  //gerrit-plugin-gwtui:gwtui-api-javadoc
  //gerrit-plugin-gwtui:gwtui-api-src

[1] facebook/buck#128

Change-Id: I6c8ddb40ef95ee45f6b6605e74381d55524229af
  • Loading branch information
@davido
davido committed Jun 17, 2015
1 parent 44c7e61 commit ce76802
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion BUCK
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ genrule(
['cd $TMP'] +
['ln -s $(location %s) .' % n for n in API_DEPS] +
['zip -q0 $OUT *']),
deps = API_DEPS,
out = 'api.zip',
)

Expand Down

0 comments on commit ce76802

Please sign in to comment.