[bop]Build RPM pkgs from OpenDev Depends On #1418

raukadah · 2024-04-08T09:06:40Z

This pull requests improves following things:

Update default value of cifmw_bop_build_repo_dir so that we can
collect DLRN related data in the logs
Change cifmw_bop_openstack_release var default value to antelope.
Introduced more vars to construct cifmw_bop_change_list.
- cifmw_bop_branchless_projects: List of project does not have stable branches.
- cifmw_bop_skipped_projects: List of projects on which DLRN build needs to be skipped.
- cifmw_bop_change_list: Zuul Change list constructed while using Depends-On in CI to build rpm packages using DLRN.
- cifmw_bop_release_mapping: A list of openstack release names and their respective branch names.
Construct cifmw_bop_change_list from OpenDev Depends On based on the
conditions defined in README
It also updates the conditional to set proper rdo branches and update
DLRN project.ini for branchful and branchless project.
For branchful project: rdo-{project branch}
For branchless project: rdo-{openstack_release}
for master: rdo-master
Add tasks to clone proper changes from gerrit refspec and github pull
requests.
Builds the RPM after that.

Test Results: openstack-k8s-operators/tcib#162 (comment)

As a pull request owner and reviewers, I checked that:

Appropriate testing is done and actually running
Appropriate documentation exists and/or is up-to-date:
- README in the role
- Content of the docs/source is reflecting the changes

Depends-On: https://review.opendev.org/c/openstack/neutron/+/914916 Depends-On: openstack-k8s-operators/ci-framework#1418 Signed-off-by: Chandan Kumar <raukadah@gmail.com>

danpawlik · 2024-04-08T10:29:08Z

recheck

Depends-On: https://review.opendev.org/c/openstack/neutron/+/914916 Depends-On: openstack-k8s-operators/ci-framework#1418 Signed-off-by: Chandan Kumar <raukadah@gmail.com>

raukadah · 2024-04-15T10:11:49Z

/hold cancel

cescgina · 2024-04-15T10:27:38Z

roles/build_openstack_packages/tasks/create_repo.yml

- name: Create a directory to hold the rpms
-  ansible.builtin.file:
-    path: '{{ cifmw_bop_gating_repo }}'
+- name: Create a temproary directory to hold the rpms


nit s/temproary/temporary

same change exists in #1457 are you going to merge them into one review or update one of them/rebase?

cjeanner · 2024-04-15T11:14:32Z

Care to trigger a molecule job for the pkg_build role? It's dependent and we already broke it with changes in bop role :) (also asked on #1457 - I see it's included in this PR, so you can trigger with a depends-on this 1418 one)

cjeanner · 2024-04-15T12:16:57Z

/hold

let's wait for #1457 to merge first if you don't mind.

softwarefactory-project-zuul · 2024-04-15T12:47:18Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/3087ab7effbb463ca6df23a589420ce4

✔️ openstack-k8s-operators-content-provider SUCCESS in 46m 36s
❌ podified-multinode-edpm-deployment-crc FAILURE in 28m 18s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 36s (non-voting)
✔️ cifmw-tcib SUCCESS in 36m 23s
✔️ cifmw-molecule-build_openstack_packages SUCCESS in 11m 49s
✔️ cifmw-molecule-pkg_build SUCCESS in 11m 35s

marios · 2024-04-16T05:30:11Z

roles/build_openstack_packages/README.md

@@ -16,23 +16,65 @@ An Ansible role for generating custom RPMSs of OpenStack Projects using DLRN
 * `cifmw_bop_openstack_release`: (String) The default release of OpenStack project. Defaults to `master`.
 * `cifmw_bop_osp_release`: (String) The downstream openstack release name.
 * `cifmw_bop_openstack_project_path`: (String) The full path of openstack cloned project to be built.
-* `cifmw_bop_gating_repo`: (String) The path of directory to store the generated rpms.
+* `cifmw_bop_gating_repo_dest`: (String) The path of directory to store gating repo file and repo metadata.


this is also added in https://github.com/openstack-k8s-operators/ci-framework/pull/1457/files

Thank you @marios for the review, PR#1457 is now merged. I have rebase this pr from main.

marios · 2024-04-16T05:31:06Z

roles/build_openstack_packages/tasks/create_repo.yml

- name: Create a directory to hold the rpms
-  ansible.builtin.file:
-    path: '{{ cifmw_bop_gating_repo }}'
+- name: Create a temproary directory to hold the rpms


same change exists in #1457 are you going to merge them into one review or update one of them/rebase?

cjeanner · 2024-04-16T08:06:50Z

/hold cancel
/approve

the patch went through test-project; it has been rebased against main once #1457 has merged, so we're good to go.

openshift-ci · 2024-04-16T08:06:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjeanner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cjeanner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cescgina · 2024-04-16T08:30:09Z

roles/build_openstack_packages/tasks/run_dlrn.yml

+    _project_branch: "{{ cifmw_bop_openstack_release }}"
+  when: _change.branch != cifmw_bop_openstack_release
+
+- name: Set proper branch name


Do we need this task and the one above? It looks like we always end up using the value of cifmw_bop_openstack_release.

that said, it could be done in a follow up, if this is blocking something

We need both the tasks. Let me change the wording of the task to make it clearer.

This pull requests improves following things: - Update default value of cifmw_bop_build_repo_dir so that we can collect DLRN related data in the logs - Change cifmw_bop_openstack_release var default value to antelope. - Introduced more vars to construct cifmw_bop_change_list. * `cifmw_bop_branchless_projects`: List of project does not have stable branches. * `cifmw_bop_skipped_projects`: List of projects on which DLRN build needs to be skipped. * `cifmw_bop_change_list`: Zuul Change list constructed while using Depends-On in CI to build rpm packages using DLRN. * `cifmw_bop_release_mapping`: A list of openstack release names and their respective branch names. - Construct cifmw_bop_change_list from OpenDev Depends On based on the conditions defined in README - It also updates the conditional to set proper rdo branches and update DLRN project.ini for branchful and branchless project. For branchful project: rdo-{project branch} For branchless project: rdo-{openstack_release} for master: rdo-master - Add tasks to clone proper changes from gerrit refspec and github pull requests. - Builds the RPM after that. Signed-off-by: Chandan Kumar <raukadah@gmail.com>

raukadah · 2024-04-16T15:14:20Z

recheck

openshift-ci bot added the do-not-merge/work-in-progress label Apr 8, 2024

openshift-ci bot requested review from dsariel and frenzyfriday April 8, 2024 09:06

raukadah marked this pull request as draft April 8, 2024 09:06

raukadah force-pushed the zuul_build_os_packages branch from 0fa3882 to 2109509 Compare April 8, 2024 09:11

raukadah mentioned this pull request Apr 8, 2024

[DNM] Build dlrn packages from opendev changes openstack-k8s-operators/tcib#162

Closed

raukadah force-pushed the zuul_build_os_packages branch 2 times, most recently from 1a5fb41 to 49927cb Compare April 8, 2024 09:34

raukadah force-pushed the zuul_build_os_packages branch from 49927cb to 09e1dc3 Compare April 8, 2024 09:54

raukadah force-pushed the zuul_build_os_packages branch from 09e1dc3 to 5648b03 Compare April 8, 2024 10:06

raukadah force-pushed the zuul_build_os_packages branch from 5648b03 to 3657885 Compare April 8, 2024 10:16

raukadah force-pushed the zuul_build_os_packages branch from 3657885 to 1c17851 Compare April 8, 2024 10:44

raukadah force-pushed the zuul_build_os_packages branch from 1c17851 to c69fc5d Compare April 8, 2024 11:06

raukadah force-pushed the zuul_build_os_packages branch from c69fc5d to 5596344 Compare April 8, 2024 11:15

raukadah force-pushed the zuul_build_os_packages branch from 5596344 to 8d65170 Compare April 8, 2024 12:09

raukadah force-pushed the zuul_build_os_packages branch from 8d65170 to 016aa28 Compare April 8, 2024 12:37

raukadah force-pushed the zuul_build_os_packages branch from 016aa28 to 41f1d3d Compare April 8, 2024 12:48

raukadah force-pushed the zuul_build_os_packages branch from 41f1d3d to 50b3c5a Compare April 8, 2024 13:01

raukadah force-pushed the zuul_build_os_packages branch 4 times, most recently from 23e9ecd to 49fcdb0 Compare April 15, 2024 08:12

openshift-ci bot removed the do-not-merge/hold label Apr 15, 2024

cescgina reviewed Apr 15, 2024

View reviewed changes

cescgina approved these changes Apr 15, 2024

View reviewed changes

openshift-ci bot assigned cescgina Apr 15, 2024

openshift-ci bot added the lgtm label Apr 15, 2024

raukadah force-pushed the zuul_build_os_packages branch from 49fcdb0 to 681bca5 Compare April 15, 2024 11:58

openshift-ci bot removed the lgtm label Apr 15, 2024

openshift-ci bot added the do-not-merge/hold label Apr 15, 2024

marios reviewed Apr 16, 2024

View reviewed changes

raukadah force-pushed the zuul_build_os_packages branch from 681bca5 to 56052d1 Compare April 16, 2024 05:47

openshift-ci bot removed the do-not-merge/hold label Apr 16, 2024

openshift-ci bot added the approved label Apr 16, 2024

cescgina reviewed Apr 16, 2024

View reviewed changes

raukadah force-pushed the zuul_build_os_packages branch from 56052d1 to 74a4e69 Compare April 16, 2024 11:19

cescgina approved these changes Apr 16, 2024

View reviewed changes

openshift-ci bot added the lgtm label Apr 16, 2024

openshift-merge-bot bot merged commit 2335a7a into main Apr 16, 2024
8 checks passed

openshift-merge-bot bot deleted the zuul_build_os_packages branch April 16, 2024 17:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[bop]Build RPM pkgs from OpenDev Depends On #1418

[bop]Build RPM pkgs from OpenDev Depends On #1418

raukadah commented Apr 8, 2024 •

edited

danpawlik commented Apr 8, 2024

raukadah commented Apr 15, 2024

cescgina Apr 15, 2024

marios Apr 16, 2024

cjeanner commented Apr 15, 2024

cjeanner commented Apr 15, 2024

softwarefactory-project-zuul bot commented Apr 15, 2024

marios Apr 16, 2024

raukadah Apr 16, 2024

marios Apr 16, 2024

cjeanner commented Apr 16, 2024

openshift-ci bot commented Apr 16, 2024

cescgina Apr 16, 2024

cescgina Apr 16, 2024

raukadah Apr 16, 2024

raukadah commented Apr 16, 2024

[bop]Build RPM pkgs from OpenDev Depends On #1418

[bop]Build RPM pkgs from OpenDev Depends On #1418

Conversation

raukadah commented Apr 8, 2024 • edited

danpawlik commented Apr 8, 2024

raukadah commented Apr 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cjeanner commented Apr 15, 2024

cjeanner commented Apr 15, 2024

softwarefactory-project-zuul bot commented Apr 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cjeanner commented Apr 16, 2024

openshift-ci bot commented Apr 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

raukadah commented Apr 16, 2024

raukadah commented Apr 8, 2024 •

edited