-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve gating content generation in build_openstack_packages role #1457
Conversation
- name: Create a directory to hold the rpms | ||
ansible.builtin.file: | ||
path: '{{ cifmw_bop_gating_repo }}' | ||
- name: Create a temprory directory to hold the rpms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: temporary
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/e4469835e1b94a62b0bece6e427219f0 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 27m 16s |
ef8c5be
to
7879e22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, left a small comment
/lgtm |
Care to trigger a molecule job for the pkg_build role? It's dependent and we already broke it with changes in bop role :) |
This pull requests improves following things: - Renames gating repo var to cifmw_bop_gating_repo_dest to store repo file and generated repo metadata at one place. - Use temp directory to copy all build rpms and generate repos content in temp directory - Drops the compress repo task as it is no longer needed. - Removes the tcib specific task from under create_repo task file Signed-off-by: Chandan Kumar <raukadah@gmail.com>
/approve Thanks for checking the pkg_build! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjeanner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/2a2e101d5aad4b538d5b3dac2d23ae40 ✔️ openstack-k8s-operators-content-provider SUCCESS in 48m 01s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/e84bae4b6a8448da820a888c1de2c041 ✔️ openstack-k8s-operators-content-provider SUCCESS in 44m 24s |
recheck |
1 similar comment
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks sane ;)
This pull requests improves following things:
As a pull request owner and reviewers, I checked that: