Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gating content generation in build_openstack_packages role #1457

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

raukadah
Copy link
Contributor

@raukadah raukadah commented Apr 12, 2024

This pull requests improves following things:

  • Renames gating repo var to cifmw_bop_gating_repo_dest to store repo file and generated repo metadata at one place.
  • Use temp directory to copy all build rpms and generate repos content in temp directory
  • Drops the compress repo task as it is no longer needed.
  • Removes the tcib specific task from under create_repo task file

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running

- name: Create a directory to hold the rpms
ansible.builtin.file:
path: '{{ cifmw_bop_gating_repo }}'
- name: Create a temprory directory to hold the rpms
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: temporary

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/e4469835e1b94a62b0bece6e427219f0

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 27m 16s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 08m 30s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 23s (non-voting)
cifmw-tcib FAILURE in 5m 09s
cifmw-molecule-build_openstack_packages FAILURE in 5m 00s

@raukadah raukadah force-pushed the gating_repo branch 3 times, most recently from ef8c5be to 7879e22 Compare April 12, 2024 12:14
Copy link
Contributor

@cescgina cescgina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left a small comment

@frenzyfriday
Copy link
Contributor

/lgtm

@cjeanner
Copy link
Collaborator

Care to trigger a molecule job for the pkg_build role? It's dependent and we already broke it with changes in bop role :)

This pull requests improves following things:
- Renames gating repo var to cifmw_bop_gating_repo_dest to store
  repo file and generated repo metadata at one place.
- Use temp directory to copy all build rpms and generate repos content
  in temp directory
- Drops the compress repo task as it is no longer needed.
- Removes the tcib specific task from under create_repo task file

Signed-off-by: Chandan Kumar <raukadah@gmail.com>
@cjeanner
Copy link
Collaborator

/approve

Thanks for checking the pkg_build!

Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjeanner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/2a2e101d5aad4b538d5b3dac2d23ae40

✔️ openstack-k8s-operators-content-provider SUCCESS in 48m 01s
podified-multinode-edpm-deployment-crc FAILURE in 29m 52s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 22s (non-voting)
✔️ cifmw-tcib SUCCESS in 40m 35s
✔️ cifmw-molecule-build_openstack_packages SUCCESS in 12m 44s
✔️ cifmw-molecule-pkg_build SUCCESS in 15m 14s

@raukadah
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/e84bae4b6a8448da820a888c1de2c041

✔️ openstack-k8s-operators-content-provider SUCCESS in 44m 24s
podified-multinode-edpm-deployment-crc FAILURE in 25m 16s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 09s (non-voting)
✔️ cifmw-tcib SUCCESS in 38m 42s
✔️ cifmw-molecule-build_openstack_packages SUCCESS in 10m 05s
✔️ cifmw-molecule-pkg_build SUCCESS in 11m 27s

@rlandy
Copy link
Contributor

rlandy commented Apr 15, 2024

recheck

1 similar comment
@danpawlik
Copy link
Contributor

recheck

Copy link
Contributor

@marios marios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sane ;)

@openshift-ci openshift-ci bot added the lgtm label Apr 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1c1e78a into main Apr 16, 2024
8 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the gating_repo branch April 16, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants