Add manila db purge job #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmount
force-pushed
the
db_purge
branch
2 times, most recently
from
dd27f4f
to
e25e93d
Compare
fmount
added a commit
to fmount/openstack-must-gather
that referenced
this pull request
Sep 27, 2023
As part of the gathering, collect the k8s CronJobs definition. Manila added the db purge cronJob in [1], and keyston has already a scheduled cronjob. [1] openstack-k8s-operators/manila-operator#142 Signed-off-by: Francesco Pantano <fpantano@redhat.com>
fmount
added a commit
to fmount/openstack-must-gather
that referenced
this pull request
Sep 27, 2023
As part of the gathering, collect the k8s `CronJob` definitions. `Manila`, for instance, added the db purge `cronJob` via [1], and keystone has already a scheduled `cronjob` [2]. [1] openstack-k8s-operators/manila-operator#142 [2] https://github.com/openstack-k8s-operators/keystone-operator/blob/main/pkg/keystone/cronjob.go Signed-off-by: Francesco Pantano <fpantano@redhat.com>
|
@gouthampacha @silvacarloss if we manage to get this patch in before I create the |
|
/test manila-operator-build-deploy-kuttl |
|
/lgtm |
Since Ocata release [1], Manila provides a utility command to purge deleted rows from database [2], and this command can be executed periodically to avoid database tables from getting bigger. This patch introduces a Manila CronJob to periodically run manila-manage db purge, so that soft-deleted records are removed from Manila database. The CronScheduling is not exposed through the CR API but it's aligned with the default values defined for TripleO based deployments. [1] https://specs.openstack.org/openstack/manila-specs/specs/ocata/add-db-manage-purge.html [2] https://docs.openstack.org/manila/latest/cli/manila-manage.html Signed-off-by: Francesco Pantano <fpantano@redhat.com>
|
/test manila-operator-build-deploy-tempest |
vhariria
approved these changes
Sep 27, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount, vhariria The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 91a9211
into
openstack-k8s-operators:main
8 checks passed
|
tardy lgtm - thanks for the changes, Francesco |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
Ocatarelease [1],Manilaprovides a utility command to purge deleted rows from database [2], and this command can be executed periodically to avoid database tables from getting bigger.This patch introduces a
ManilaCronJobto periodically runmanila-manage db purge, so that soft-deleted records are removed fromManiladatabase.The
Cronscheduling is not exposed through the CR APIs but it's aligned with the default values defined forTripleObased deployments.[1] https://specs.openstack.org/openstack/manila-specs/specs/ocata/add-db-manage-purge.html
[2] https://docs.openstack.org/manila/latest/cli/manila-manage.html