Skip to content

Commit

Permalink
Add ploop to supported disk_formats
Browse files Browse the repository at this point in the history
Lite-Spec-Id:Ib45de5ff2fe7fc4e1c2d6f8cb6772e017ef891c2
Change-Id: Ice74c4bf9ed2efae519930f33b2fa2b3c162e8c4
  • Loading branch information
mnestratov committed Dec 22, 2016
1 parent 075015f commit ab7152e
Show file tree
Hide file tree
Showing 9 changed files with 24 additions and 7 deletions.
3 changes: 2 additions & 1 deletion api-ref/source/v2/samples/schemas-image-show-response.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@
"raw",
"qcow2",
"vdi",
"iso"
"iso",
"ploop"
],
"type": [
"null",
Expand Down
3 changes: 2 additions & 1 deletion api-ref/source/v2/samples/schemas-images-list-response.json
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,8 @@
"raw",
"qcow2",
"vdi",
"iso"
"iso",
"ploop"
],
"type": [
"null",
Expand Down
2 changes: 1 addition & 1 deletion doc/source/configuring.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1700,4 +1700,4 @@ done by setting the ``disk_formats`` parameter which is found in the

* ``disk_formats=<Comma separated list of disk formats>``

Optional. Default: ``ami,ari,aki,vhd,vmdk,raw,qcow2,vdi,iso``
Optional. Default: ``ami,ari,aki,vhd,vmdk,raw,qcow2,vdi,iso,ploop``
4 changes: 4 additions & 0 deletions doc/source/formats.rst
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ You can set your image's disk format to one of the following:

An archive format for the data contents of an optical disc (e.g. CDROM).

* **ploop**

A disk format supported and used by Virtuozzo to run OS Containers

* **qcow2**

A disk format supported by the QEMU emulator that can expand dynamically and
Expand Down
2 changes: 1 addition & 1 deletion doc/source/glanceapi.rst
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ The list of metadata headers that Glance accepts are listed below.

This header is required, unless reserving an image. Valid values are one of
``aki``, ``ari``, ``ami``, ``raw``, ``iso``, ``vhd``, ``vhdx``, ``vdi``,
``qcow2``, or ``vmdk``.
``qcow2``, ``vmdk`` or ``ploop``.

For more information, see :doc:`About Disk and Container Formats <formats>`.

Expand Down
2 changes: 1 addition & 1 deletion etc/glance-api.conf
Original file line number Diff line number Diff line change
Expand Up @@ -3266,7 +3266,7 @@

# Supported values for the 'disk_format' image attribute (list value)
# Deprecated group/name - [DEFAULT]/disk_formats
#disk_formats = ami,ari,aki,vhd,vhdx,vmdk,raw,qcow2,vdi,iso
#disk_formats = ami,ari,aki,vhd,vhdx,vmdk,raw,qcow2,vdi,iso,ploop


[keystone_authtoken]
Expand Down
2 changes: 1 addition & 1 deletion glance/common/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
group='DEFAULT')]),
cfg.ListOpt('disk_formats',
default=['ami', 'ari', 'aki', 'vhd', 'vhdx', 'vmdk', 'raw',
'qcow2', 'vdi', 'iso'],
'qcow2', 'vdi', 'iso', 'ploop'],
help=_("Supported values for the 'disk_format' "
"image attribute"),
deprecated_opts=[cfg.DeprecatedOpt('disk_formats',
Expand Down
2 changes: 1 addition & 1 deletion glance/tests/unit/v2/test_images_resource.py
Original file line number Diff line number Diff line change
Expand Up @@ -3837,7 +3837,7 @@ class TestImageSchemaFormatConfiguration(test_utils.BaseTestCase):
def test_default_disk_formats(self):
schema = glance.api.v2.images.get_schema()
expected = [None, 'ami', 'ari', 'aki', 'vhd', 'vhdx', 'vmdk',
'raw', 'qcow2', 'vdi', 'iso']
'raw', 'qcow2', 'vdi', 'iso', 'ploop']
actual = schema.properties['disk_format']['enum']
self.assertEqual(expected, actual)

Expand Down
11 changes: 11 additions & 0 deletions releasenotes/notes/add-ploop-format-fdd583849504ab15.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
prelude: >
- Add ``ploop`` to the list of supported disk formats.
features:
- The identifier ``ploop`` has been added to the list of
supported disk formats in Glance. The respective
configuration option has been updated and the default
list shows ``ploop`` as a supported format.
upgrade:
- The ``disk_format`` config option enables ``ploop`` as
supported by default.

0 comments on commit ab7152e

Please sign in to comment.