Updated bp keystone-configuration for bp keystone-manage2

- Centralized sql_connection method
- Avoided initializing commands that weren't being called

Change-Id: I8231ed4ee4c384f948703b5620acef9f27265f55

keystone/manage2/__init__.py

@@ -44,8 +44,7 @@ def main():
         subparser = subparsers.add_parser(module_name,
                 help=module.Command.__doc__)
 
-        cmd = module.Command()
-        cmd.append_parser(subparser)
+        module.Command.append_parser(subparser)
 
     # actually parse the command line args or print help
     args = parser.parse_args()

keystone/manage2/base.py

@@ -1,5 +1,6 @@
 import argparse
 
+from keystone import config
 from keystone.manage2 import common
 
 
@@ -8,9 +9,6 @@ class BaseCommand(object):
 
     # pylint: disable=W0613
     def __init__(self, *args, **kwargs):
-        if not hasattr(self.__class__, '_args'):
-            self.__class__._args = {}
-
         self.parser = argparse.ArgumentParser(prog=self.__module__,
             description=self.__doc__)
         self.append_parser(self.parser)
@@ -35,7 +33,7 @@ def append_parser(cls, parser):
 
         :param parser: argparse.ArgumentParser
         """
-        args = cls._args
+        args = getattr(cls, '_args', {})
 
         for name in args.keys():
             try:
@@ -59,6 +57,11 @@ class BaseSqlalchemyCommand(BaseCommand):
     def __init__(self, *args, **kwargs):
         super(BaseSqlalchemyCommand, self).__init__(*args, **kwargs)
 
+    @staticmethod
+    def _get_connection_string():
+        sqla = config.CONF['keystone.backends.sqlalchemy']
+        return sqla.sql_connection
+
 
 # pylint: disable=E1101,W0223
 class BaseBackendCommand(BaseCommand):

keystone/manage2/commands/downgrade_database.py

@@ -1,5 +1,4 @@
 from keystone.backends.sqlalchemy import migration
-from keystone import config
 from keystone.manage2 import base
 from keystone.manage2 import common
 
@@ -10,11 +9,6 @@
 class Command(base.BaseSqlalchemyCommand):
     """Downgrades the database to the specified version"""
 
-    @staticmethod
-    def _get_connection_string():
-        sqla = config.CONF['keystone.backends.sqlalchemy']
-        return sqla.sql_connection
-
     @staticmethod
     def downgrade_database(version):
         """Downgrade database to the specified version"""

keystone/manage2/commands/goto_database.py

@@ -1,5 +1,4 @@
 from keystone.backends.sqlalchemy import migration
-from keystone import config
 from keystone.manage2 import base
 from keystone.manage2 import common
 
@@ -15,11 +14,6 @@ class Command(base.BaseSqlalchemyCommand):
 
     """
 
-    @staticmethod
-    def _get_connection_string():
-        sqla = config.CONF['keystone.backends.sqlalchemy']
-        return sqla.sql_connection
-
     @staticmethod
     def goto_database_version(version):
         """Override database's current migration level"""

keystone/manage2/commands/sync_database.py

@@ -1,5 +1,4 @@
 from keystone.backends.sqlalchemy import migration
-from keystone import config
 from keystone.manage2 import base
 from keystone.manage2 import common
 
@@ -10,11 +9,6 @@
 class Command(base.BaseSqlalchemyCommand):
     """Upgrades the database to the latest schema."""
 
-    @staticmethod
-    def _get_connection_string():
-        sqla = config.CONF['keystone.backends.sqlalchemy']
-        return sqla.sql_connection
-
     @staticmethod
     def sync_database(version=None):
         """Place database under migration control & automatically upgrade"""

keystone/manage2/commands/upgrade_database.py

@@ -1,5 +1,4 @@
 from keystone.backends.sqlalchemy import migration
-from keystone import config
 from keystone.manage2 import base
 from keystone.manage2 import common
 
@@ -10,11 +9,6 @@
 class Command(base.BaseSqlalchemyCommand):
     """Upgrades the database to the specified version."""
 
-    @staticmethod
-    def _get_connection_string():
-        sqla = config.CONF['keystone.backends.sqlalchemy']
-        return sqla.sql_connection
-
     @staticmethod
     def upgrade_database(version):
         """Upgrade database to the specified version"""

keystone/manage2/commands/version.py

@@ -1,5 +1,4 @@
 from keystone.backends.sqlalchemy import migration
-from keystone import config
 from keystone import version
 from keystone.manage2 import base
 from keystone.manage2 import common
@@ -27,11 +26,6 @@ def get_api_version():
         """Returns a complete API version string"""
         return ' '.join([version.API_VERSION, version.API_VERSION_STATUS])
 
-    @staticmethod
-    def _get_connection_string():
-        sqla = config.CONF['keystone.backends.sqlalchemy']
-        return sqla.sql_connection
-
     @staticmethod
     def get_implementation_version():
         """Returns a complete implementation version string"""

keystone/manage2/commands/version_control_database.py

@@ -1,16 +1,10 @@
 from keystone.backends.sqlalchemy import migration
-from keystone import config
 from keystone.manage2 import base
 
 
 class Command(base.BaseSqlalchemyCommand):
     """Places an existing database under version control."""
 
-    @staticmethod
-    def _get_connection_string():
-        sqla = config.CONF['keystone.backends.sqlalchemy']
-        return sqla.sql_connection
-
     @staticmethod
     def version_control_database():
         """Place database under migration control"""

keystone/manage2/common.py

@@ -30,7 +30,7 @@ def _decorator(cls):
 
 def get_options():
     # Initialize a parser for our configuration paramaters
-    parser = optparse.OptionParser("usage", version='%%prog %s'
+    parser = optparse.OptionParser("Usage", version='%%prog %s'
         % version.version())
     config.add_common_options(parser)
     config.add_log_options(parser)

keystone/test/client/test_keystone_manage.py

@@ -30,7 +30,7 @@ def test_check_can_call_keystone_manage(self):
         ]
         process = subprocess.Popen(cmd, stdout=subprocess.PIPE)
         result = process.communicate()[0]
-        self.assertIn('Usage', result)
+        self.assertIn('usage', result.lower())
 
     def test_keystone_manage_calls(self):
         """