Skip to content

Commit

Permalink
baremetal: Install Docker SDK less than 5.0.0
Browse files Browse the repository at this point in the history
Docker 5.0.0 [1] dropped requirement for six, but still imports it.

[1]: docker/docker-py#2807

Closes-Bug: #1928915
Change-Id: I726541f4b3fdc357387a44c6a2153593a10bf282
(cherry picked from commit b053bd8)
  • Loading branch information
mnasiadka authored and yoctozepto committed May 19, 2021
1 parent 4a7e2ae commit b97b388
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
3 changes: 2 additions & 1 deletion ansible/roles/baremetal/tasks/install.yml
Expand Up @@ -116,7 +116,8 @@
- name: Install docker SDK for python
pip:
# NOTE(hrw) docker 2.4.2 is in kolla-ansible requirements
name: docker>=2.4.2
# NOTE(mnasiadka): docker 5.0.0 lacks six in deps but requires it
name: docker>=2.4.2,<5.0.0
executable: "{{ virtualenv is none | ternary('pip3', omit) }}"
virtualenv: "{{ virtualenv is none | ternary(omit, virtualenv) }}"
virtualenv_site_packages: "{{ virtualenv is none | ternary(omit, virtualenv_site_packages) }}"
Expand Down
6 changes: 6 additions & 0 deletions releasenotes/notes/bug-1928915-482b2d53bb2a4d92.yaml
@@ -0,0 +1,6 @@
---
fixes:
- |
Fixed an issue where docker python SDK 5.0.0 was failing due to missing
six - introduced a constraint to install version lower than 5.x.
`LP#1928915 <https://launchpad.net/bugs/1928915>`__

0 comments on commit b97b388

Please sign in to comment.