Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0.0] Dropped dependency six but remains importing six in 32 Python files? #2807

Closed
hartwork opened this issue Apr 6, 2021 · 10 comments
Closed

[5.0.0] Dropped dependency six but remains importing six in 32 Python files? #2807

hartwork opened this issue Apr 6, 2021 · 10 comments
Assignees
@feliperuhland

Comments

@hartwork
Copy link

hartwork commented Apr 6, 2021 •
edited

Hi!

While bumping docker-py for Gentoo I noticed that commit c8fba21 dropped the dependency on six from setup.py and requirements.txt. When grepping the sources I find 32 more Python files that still import six so I would expect some trouble at runtime in an environment where no six is available (if we ignore dependencies pulling six in, indirectly). Is that known and intended?

Thanks and best, Sebastian
@feliperuhland
Copy link
Contributor

Hi @hartwork

That makes total sense, and we will remove those dependencies.

@ulyssessouza could you assign this issue to me?

Thanks and have a good day :)

@jeffreyc-splunk jeffreyc-splunk mentioned this issue May 18, 2021
Merged
@consideRatio
Copy link

consideRatio commented May 18, 2021 •
edited

Thank you @hartwork for reporting this issue, and everyone involved contributing to this project! ❤️ 🎉

@feliperuhland are you still interested in working on this?

Thank you again everyone contributing to this project, I'm one among many users who rely on it indirectly ❤️

@consideRatio consideRatio mentioned this issue May 18, 2021
Merged
openstack-mirroring pushed a commit to openstack/kolla-ansible that referenced this issue May 19, 2021
@mnasiadka
baremetal: Install Docker SDK less than 5.0.0
b053bd8 
Docker 5.0.0 [1] dropped requirement for six, but still imports it.

[1]: docker/docker-py#2807

Closes-Bug: #1928915
Change-Id: I726541f4b3fdc357387a44c6a2153593a10bf282
openstack-mirroring pushed a commit to openstack/openstack that referenced this issue May 19, 2021
@openstack-gerrit
Update git submodules
c6e8f79 
* Update kolla-ansible from branch 'master'
  to bb3653b96692658b55bd54d757f621f398984139
  - Merge "baremetal: Install Docker SDK less than 5.0.0"
  - baremetal: Install Docker SDK less than 5.0.0
    
    Docker 5.0.0 [1] dropped requirement for six, but still imports it.
    
    [1]: docker/docker-py#2807
    
    Closes-Bug: #1928915
    Change-Id: I726541f4b3fdc357387a44c6a2153593a10bf282
openstack-mirroring pushed a commit to openstack/kolla-ansible that referenced this issue May 19, 2021
@mnasiadka @yoctozepto
baremetal: Install Docker SDK less than 5.0.0
ee8bd45 
Docker 5.0.0 [1] dropped requirement for six, but still imports it.

[1]: docker/docker-py#2807

Closes-Bug: #1928915
Change-Id: I726541f4b3fdc357387a44c6a2153593a10bf282
(cherry picked from commit b053bd8)
openstack-mirroring pushed a commit to openstack/kolla-ansible that referenced this issue May 19, 2021
@mnasiadka @yoctozepto
baremetal: Install Docker SDK less than 5.0.0
56eefd8 
Docker 5.0.0 [1] dropped requirement for six, but still imports it.

[1]: docker/docker-py#2807

Closes-Bug: #1928915
Change-Id: I726541f4b3fdc357387a44c6a2153593a10bf282
(cherry picked from commit b053bd8)
openstack-mirroring pushed a commit to openstack/kolla-ansible that referenced this issue May 19, 2021
@mnasiadka @yoctozepto
baremetal: Install Docker SDK less than 5.0.0
b97b388 
Docker 5.0.0 [1] dropped requirement for six, but still imports it.

[1]: docker/docker-py#2807

Closes-Bug: #1928915
Change-Id: I726541f4b3fdc357387a44c6a2153593a10bf282
(cherry picked from commit b053bd8)
openstack-mirroring pushed a commit to openstack/kolla-ansible that referenced this issue May 20, 2021
@mnasiadka @yoctozepto
baremetal: Install Docker SDK less than 5.0.0
5ef5870 
Docker 5.0.0 [1] dropped requirement for six, but still imports it.

[1]: docker/docker-py#2807

Closes-Bug: #1928915
Change-Id: I726541f4b3fdc357387a44c6a2153593a10bf282
(cherry picked from commit b053bd8)
@cliffwoolley cliffwoolley mentioned this issue May 20, 2021
Closed
@thaJeztah thaJeztah mentioned this issue May 20, 2021
Closed
NitzKo95 added a commit to NitzKo95/docker-py that referenced this issue May 20, 2021
@NitzKo95
Add six to requirements.txt
6010c90 
Signed-off-by: Nitzan Kohan <nitzan@cognata.com>
- fixes docker#2807
- fixes docker#2842
@feliperuhland
Copy link
Contributor

I won't be able to finish that task.

Have a nice day.

@hartwork
Copy link
Author

@feliperuhland thanks for being transparent about it.

@aiordache this seems like a low hanging fruit, yet somewhat important. Are you aware of someone who can take over? Else: If I came up with a pull request myself, would you have a minute for review in the next few days?

@feliperuhland
Copy link
Contributor

Hi @hartwork

I'm going to dedicate my time to other projects.
I have a small WIP here https://github.com/feliperuhland/docker-py/pull/new/remove-six

I hope that helps.

@hartwork
Copy link
Author

hartwork commented May 23, 2021 •
edited

Thanks.

Here's a direct link to @feliperuhland's W.I.P. commit if anyone else wants to have a look:
feliperuhland@71411f5

Nicceboy added a commit to cincanproject/cincan-registry that referenced this issue May 24, 2021
@Nicceboy
fix six dependency, related to docker/docker-py#2807
875322a
@consideRatio consideRatio mentioned this issue May 28, 2021
Merged
@seanctech seanctech mentioned this issue Jun 4, 2021
Merged
4 tasks
matofeder pushed a commit to dNationCloud/kubernetes-monitoring that referenced this issue Jun 7, 2021
FIXME: six is required by docker 5.0.0 but isn't explicitly required
65fb90b 
docker/docker-py#2807
matofeder pushed a commit to dNationCloud/kubernetes-monitoring-stack that referenced this issue Jun 7, 2021
FIXME: six is required by docker 5.0.0 but isn't explicitly required
be5163f 
docker/docker-py#2807

Signed-off-by: Matej Feder <matej.feder@ifne.eu>
tfoote added a commit to osrf/rocker that referenced this issue Jun 8, 2021
@tfoote
Workaround missing upstream dependency on six
6d268d1 
From: docker/docker-py#2807
@tfoote tfoote mentioned this issue Jun 8, 2021
Merged
tfoote added a commit to osrf/rocker that referenced this issue Jun 8, 2021
@tfoote
Workaround missing upstream dependency on six (#151)
89be45b 
From: docker/docker-py#2807
@akashchi akashchi mentioned this issue Jun 21, 2021
Merged
facebook-github-bot pushed a commit to terragraph/tgnms that referenced this issue Jun 21, 2021
@aclave1 @facebook-github-bot
fix(v6up): Lock docker-py to 4.4.4
ccdc5cb 
Summary: docker-py version 5.0.0 has a bug: docker/docker-py#2807

Reviewed By: elludraon

Differential Revision: D29272818

fbshipit-source-id: b8768cbcdb3d9f763caefbb5b10f3713754d2b8e
@asottile
Copy link
Contributor

fixed in #2863

@hartwork
Copy link
Author

@asottile awesome, thank you! 🙏

@hartwork
Copy link
Author

@docker any chance for a new release?

@thaJeztah
Copy link
Member

Let me close this one, as it was fixed in #2863

I'll ask @ulyssessouza if it's possible to tag a new release

spd-intermodalics pushed a commit to Intermodalics/rocker that referenced this issue Oct 7, 2021
@tfoote @spd-intermodalics
Workaround missing upstream dependency on six (osrf#151)
95bd873 
From: docker/docker-py#2807
davidsuba pushed a commit to dNationCloud/kubernetes-monitoring that referenced this issue Jan 10, 2022
@davidsuba
FIXME: six is required by docker 5.0.0 but isn't explicitly required
6ba57fa 
docker/docker-py#2807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feliperuhland feliperuhland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add six to requirements.txt NitzKo95/docker-py
5 participants
@feliperuhland @hartwork @thaJeztah @asottile @consideRatio