Skip to content

Commit

Permalink
Remove no need LOG.exception on attach_interface
Browse files Browse the repository at this point in the history
When attach_interface, this LOG.exception will be reported
if InterfaceAttachFailed is raised from compute layer
actually, there already are LOG.error and API layer also
reported this exception, so there is no need to
raise exception here.

Change-Id: If5258c851b60cc4360f357a531610e4e52f9b26c
  • Loading branch information
jichenjc committed Jan 7, 2015
1 parent 6339f07 commit 644c89d
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion nova/api/openstack/compute/contrib/attach_interfaces.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ def create(self, req, server_id, body):
msg = _("Network driver does not support this function.")
raise webob.exc.HTTPNotImplemented(explanation=msg)
except exception.InterfaceAttachFailed as e:
LOG.exception(e)
msg = _("Failed to attach interface")
raise webob.exc.HTTPInternalServerError(explanation=msg)
except exception.InstanceInvalidState as state_error:
Expand Down

0 comments on commit 644c89d

Please sign in to comment.