Skip to content

Commit

Permalink
pypy is not checked at gate
Browse files Browse the repository at this point in the history
We also don't use python 3.4.

Change-Id: I9aa2f3770610570166fc7004df1e05da9c5e0d4a
  • Loading branch information
Saju authored and emonty committed Apr 27, 2018
1 parent 7c723f6 commit fb0d34b
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 11 deletions.
3 changes: 0 additions & 3 deletions bindep.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,3 @@ python-devel [platform:rpm]
libffi-dev [platform:dpkg]
libffi-devel [platform:rpm]
openssl-devel [platform:rpm]
pypy [pypy]
pypy-dev [platform:dpkg pypy]
pypy-devel [platform:rpm pypy]
2 changes: 1 addition & 1 deletion doc/source/contributor/setup.rst
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ the following::
To create an environment for a different version, such as Python 3, run
the following::

$ virtualenv -p python3.4 $HOME/envs/sdk3
$ virtualenv -p python3.5 $HOME/envs/sdk3

When you want to enable your environment so that you can develop inside of it,
you *activate* it. To activate an environment, run the /bin/activate
Expand Down
9 changes: 4 additions & 5 deletions doc/source/contributor/testing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -14,25 +14,24 @@ Run

In order to run the entire unit test suite, simply run the ``tox`` command
inside of your source checkout. This will attempt to run every test command
listed inside of ``tox.ini``, which includes Python 2.7, 3.4, PyPy,
listed inside of ``tox.ini``, which includes Python 2.7, 3.5,
and a PEP 8 check. You should run the full test suite on all versions before
submitting changes for review in order to avoid unexpected failures in the
continuous integration system.::

(sdk3)$ tox
...
py34: commands succeeded
py35: commands succeeded
py27: commands succeeded
pypy: commands succeeded
pep8: commands succeeded
congratulations :)

During development, it may be more convenient to run a subset of the tests
to keep test time to a minimum. You can choose to run the tests only on one
version. A step further is to run only the tests you are working on.::

(sdk3)$ tox -e py34 # Run run the tests on Python 3.4
(sdk3)$ tox -e py34 TestContainer # Run only the TestContainer tests on 3.4
(sdk3)$ tox -e py35 # Run run the tests on Python 3.5
(sdk3)$ tox -e py35 TestContainer # Run only the TestContainer tests on 3.5

Functional Tests
----------------
Expand Down
2 changes: 1 addition & 1 deletion openstack/tests/unit/cloud/test_task_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def test_wait_re_raise(self):
This test is aimed to six.reraise(), called in Task::wait().
Specifically, we test if we get the same behaviour with all the
configured interpreters (e.g. py27, p34, pypy, ...)
configured interpreters (e.g. py27, p35, ...)
"""
self.assertRaises(TestException, self.manager.submit_task, TaskTest())

Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tox]
minversion = 1.6
envlist = py35,py27,pypy,pep8
envlist = py35,py27,pep8
skipsdist = True

[testenv]
Expand Down

0 comments on commit fb0d34b

Please sign in to comment.