-
Notifications
You must be signed in to change notification settings - Fork 155
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
rabbit: make ack/requeue thread-safe
ack/requeue messages are currently done in the MessageHandlingServer._process_incoming(). But _process_incoming() in run by a futurist Executor. That can be a threading or an eventlet executor. With eventlet, we don't really share the socket between threads. But with threading executor and expecialy ssl, this can't work, if you write data with two different threads to the socket. This change moves back the message ack/requeue to the polling threads that handle the connection, instead of the threads we spawn for the application. Oslo Messaging now always use a connection in the same thread. Change-Id: I5c0e6def6b34f4d195fb1f8dbb26eda0f21ff34e
- Loading branch information
Mehdi Abaakouk
committed
Feb 22, 2017
1 parent
296d93d
commit 7e71ac8
Showing
1 changed file
with
61 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters