Pin setuptools<50 in our image venvs

setuptools==50 doesn't work with python older than python3.8. There are a number of issues [0][1][2] the first of which we are tripping over. Be conservative here and install older setuptools until these issues on python3.5, 3.6, and 3.7 are sorted out. [0] pypa/setuptools#2352 [1] https://github.com/pypa/setuptools/issues/2363 [2] pypa/setuptools#2357 Change-Id: I1ae7251c8a4c214544524871fdfe51e947b638f8
openstack · Aug 31, 2020 · 6f992ef · 6f992ef
1 parent d216a05
commit 6f992ef
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/nodepool/elements/infra-package-needs/install.d/40-install-bindep b/nodepool/elements/infra-package-needs/install.d/40-install-bindep
@@ -23,4 +23,7 @@ fi
 set -e
 
 python3 -m venv /usr/bindep-env
+# We do this first to ensure working setuptools is present when bindep
+# is installed.
+/usr/bindep-env/bin/pip install -U 'setuptools<50'
 /usr/bindep-env/bin/pip install bindep
diff --git a/nodepool/elements/infra-package-needs/install.d/40-install-tox b/nodepool/elements/infra-package-needs/install.d/40-install-tox
@@ -23,4 +23,7 @@ fi
 set -e
 
 python3 -m venv /usr/tox-env
+# We do this first to ensure working setuptools is present when tox
+# is installed.
+/usr/tox-env/bin/pip install -U 'setuptools<50'
 /usr/tox-env/bin/pip install tox
diff --git a/nodepool/elements/nodepool-base/install.d/91-venv-os-testr b/nodepool/elements/nodepool-base/install.d/91-venv-os-testr
@@ -19,4 +19,7 @@ fi
 set -e
 
 python3 -m venv /usr/os-testr-env
+# We do this first to ensure working setuptools is present when os-testr
+# is installed.
+/usr/os-testr-env/bin/pip install -U 'setuptools<50'
 /usr/os-testr-env/bin/pip install os-testr