Skip to content

Commit

Permalink
Add use_journal option for logging configuration
Browse files Browse the repository at this point in the history
This enables oslo.log to pass logging records to journald.

Change-Id: I11ad2c8557fb2e6793c5ca368d21cf08833e2f32
  • Loading branch information
zhongshengping committed Jan 15, 2018
1 parent 3bc17a6 commit 939a583
Show file tree
Hide file tree
Showing 5 changed files with 35 additions and 12 deletions.
6 changes: 6 additions & 0 deletions manifests/api/logging.pp
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@
# (Optional) Use json for logging.
# Defaults to $::os_service_default.
#
# [*use_journal*]
# (Optional) Use journal for logging.
# Defaults to $::os_service_default.
#
# [*use_stderr*]
# (optional) Use stderr for logging
# Defaults to $::os_service_default.
Expand Down Expand Up @@ -97,6 +101,7 @@
class glance::api::logging(
$use_syslog = $::os_service_default,
$use_json = $::os_service_default,
$use_journal = $::os_service_default,
$use_stderr = $::os_service_default,
$log_facility = $::os_service_default,
$log_dir = '/var/log/glance',
Expand Down Expand Up @@ -139,6 +144,7 @@
use_stderr => $use_stderr_real,
use_syslog => $use_syslog_real,
use_json => $use_json,
use_journal => $use_journal,
log_dir => $log_dir_real,
log_file => $log_file_real,
syslog_log_facility => $log_facility_real,
Expand Down
6 changes: 6 additions & 0 deletions manifests/registry/logging.pp
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@
# (Optional) Use json for logging.
# Defaults to $::os_service_default.
#
# [*use_journal*]
# (Optional) Use journal for logging.
# Defaults to $::os_service_default.
#
# [*use_stderr*]
# (optional) Use stderr for logging
# Defaults to $::os_service_default.
Expand Down Expand Up @@ -97,6 +101,7 @@
class glance::registry::logging(
$use_syslog = $::os_service_default,
$use_json = $::os_service_default,
$use_journal = $::os_service_default,
$use_stderr = $::os_service_default,
$log_facility = $::os_service_default,
$log_dir = '/var/log/glance',
Expand Down Expand Up @@ -135,6 +140,7 @@
use_stderr => $use_stderr_real,
use_syslog => $use_syslog_real,
use_json => $use_json,
use_journal => $use_journal,
log_dir => $log_dir_real,
log_file => $log_file_real,
syslog_log_facility => $log_facility_real,
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
features:
- |
Adds the use_journal option for configuring oslo.log. This will enable
passing the logs to journald.
15 changes: 9 additions & 6 deletions spec/classes/glance_api_logging_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
:log_date_format => '%Y-%m-%d %H:%M:%S',
:use_syslog => true,
:use_json => true,
:use_journal => true,
:use_stderr => false,
:log_facility => 'LOG_FOO',
:log_dir => '/var/log',
Expand Down Expand Up @@ -58,12 +59,13 @@
shared_examples 'basic default logging settings' do
it 'configures glance logging settings with default values' do
is_expected.to contain_oslo__log('glance_api_config').with(
:use_syslog => '<SERVICE DEFAULT>',
:use_json => '<SERVICE DEFAULT>',
:use_stderr => '<SERVICE DEFAULT>',
:log_dir => '/var/log/glance',
:log_file => '/var/log/glance/api.log',
:debug => '<SERVICE DEFAULT>',
:use_syslog => '<SERVICE DEFAULT>',
:use_json => '<SERVICE DEFAULT>',
:use_journal => '<SERVICE DEFAULT>',
:use_stderr => '<SERVICE DEFAULT>',
:log_dir => '/var/log/glance',
:log_file => '/var/log/glance/api.log',
:debug => '<SERVICE DEFAULT>',
)
end
end
Expand All @@ -73,6 +75,7 @@
is_expected.to contain_oslo__log('glance_api_config').with(
:use_syslog => true,
:use_json => true,
:use_journal => true,
:use_stderr => false,
:syslog_log_facility => 'LOG_FOO',
:log_dir => '/var/log',
Expand Down
15 changes: 9 additions & 6 deletions spec/classes/glance_registry_logging_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
:log_date_format => '%Y-%m-%d %H:%M:%S',
:use_syslog => true,
:use_json => true,
:use_journal => true,
:use_stderr => false,
:log_facility => 'LOG_FOO',
:log_dir => '/var/log',
Expand Down Expand Up @@ -58,12 +59,13 @@
shared_examples 'basic default logging settings' do
it 'configures glance logging settings with default values' do
is_expected.to contain_oslo__log('glance_registry_config').with(
:use_syslog => '<SERVICE DEFAULT>',
:use_json => '<SERVICE DEFAULT>',
:use_stderr => '<SERVICE DEFAULT>',
:log_dir => '/var/log/glance',
:log_file => '/var/log/glance/registry.log',
:debug => '<SERVICE DEFAULT>',
:use_syslog => '<SERVICE DEFAULT>',
:use_json => '<SERVICE DEFAULT>',
:use_journal => '<SERVICE DEFAULT>',
:use_stderr => '<SERVICE DEFAULT>',
:log_dir => '/var/log/glance',
:log_file => '/var/log/glance/registry.log',
:debug => '<SERVICE DEFAULT>',
)
end
end
Expand All @@ -73,6 +75,7 @@
is_expected.to contain_oslo__log('glance_registry_config').with(
:use_syslog => true,
:use_json => true,
:use_journal => true,
:use_stderr => false,
:syslog_log_facility => 'LOG_FOO',
:log_dir => '/var/log',
Expand Down

0 comments on commit 939a583

Please sign in to comment.