Merge "remove hacking checks from keystoneclient"

openstack · Jan 6, 2017 · 272f60d · 272f60d
2 parents 9065745 + ffdab4e
commit 272f60d
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 149 deletions.
diff --git a/keystoneclient/tests/hacking/__init__.py b/keystoneclient/tests/hacking/__init__.py
diff --git a/keystoneclient/tests/hacking/checks.py b/keystoneclient/tests/hacking/checks.py
diff --git a/keystoneclient/tests/unit/client_fixtures.py b/keystoneclient/tests/unit/client_fixtures.py
@@ -709,67 +709,6 @@ def setUp(self):
 EXAMPLES_RESOURCE = testresources.FixtureResource(Examples())
 
 
-class HackingCode(fixtures.Fixture):
-    """A fixture to house the various code examples.
-
-    Examples contains various keystoneclient hacking style checks.
-    """
-
-    oslo_namespace_imports = {
-        'code': """
-            import oslo.utils
-            import oslo_utils
-            import oslo.utils.encodeutils
-            import oslo_utils.encodeutils
-            from oslo import utils
-            from oslo.utils import encodeutils
-            from oslo_utils import encodeutils
-
-            import oslo.serialization
-            import oslo_serialization
-            import oslo.serialization.jsonutils
-            import oslo_serialization.jsonutils
-            from oslo import serialization
-            from oslo.serialization import jsonutils
-            from oslo_serialization import jsonutils
-
-            import oslo.config
-            import oslo_config
-            import oslo.config.cfg
-            import oslo_config.cfg
-            from oslo import config
-            from oslo.config import cfg
-            from oslo_config import cfg
-
-            import oslo.i18n
-            import oslo_i18n
-            import oslo.i18n.log
-            import oslo_i18n.log
-            from oslo import i18n
-            from oslo.i18n import log
-            from oslo_i18n import log
-        """,
-        'expected_errors': [
-            (1, 0, 'K333'),
-            (3, 0, 'K333'),
-            (5, 0, 'K333'),
-            (6, 0, 'K333'),
-            (9, 0, 'K333'),
-            (11, 0, 'K333'),
-            (13, 0, 'K333'),
-            (14, 0, 'K333'),
-            (17, 0, 'K333'),
-            (19, 0, 'K333'),
-            (21, 0, 'K333'),
-            (22, 0, 'K333'),
-            (25, 0, 'K333'),
-            (27, 0, 'K333'),
-            (29, 0, 'K333'),
-            (30, 0, 'K333'),
-        ],
-    }
-
-
 class Deprecations(fixtures.Fixture):
     def setUp(self):
         super(Deprecations, self).setUp()

diff --git a/keystoneclient/tests/unit/test_hacking_checks.py b/keystoneclient/tests/unit/test_hacking_checks.py
diff --git a/tox.ini b/tox.ini
@@ -64,7 +64,6 @@ commands = sphinx-build -a -E -W -d releasenotes/build/doctrees -b html releasen
 [hacking]
 import_exceptions =
     keystoneclient.i18n
-local-check-factory = keystoneclient.tests.hacking.checks.factory
 
 [testenv:bindep]
 # Do not install any requirements. We want this to be fast and work even if