fix: add fallback to tag when branch could not be fetched via git #390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the docker image we don't include any git history and this breaks the logic to dynamically parse a version for the used CDN endpoints. With this fix we introduce a new
CDN_DIST_TAG
environment variable which can be used to fetch dist-tagged versions from npm (eg.alpha
,beta
,latest
) and will resolve it to a release version (eg.latest
->1.0.3
,alpha
->1.0.0-alpha.3
). This is helpful to circumvent caching issues by browsers.Type of change
Bug fix / improvement
Tests
Use a docker image with the
CDN_DIST_TAG
environment variable. Your console should log that it can't use git to determine the branch and it will fallback to the given tag.Tested on openstad-ams-staging cluster
Branch
Based of master/main, not development