Sort HW builder's chapter sections so they appear in order #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nathanstitt
commented
Jul 28, 2015
nathanstitt
commented
nathanstitt
force-pushed
the
fix/progress-bar-color
branch
from
8f71bc5
to
14cdb01
Compare
|
I somehow used the wrong branch name on this, hence the name "progress-bar-color". I didn't notice until I'd opened the PR, so "A rose by any other name would smell as sweet" (or stinky as it might be) |
| @@ -20,7 +20,7 @@ PLAN_TYPES = | |||
| sortTopics = (topics) -> | |||
| _.sortBy(topics, (topicId) -> | |||
| topic = TocStore.getSectionInfo(topicId) | |||
| topic.chapter_section.toString() | |||
| TaskHelpers.chapterSectionToNumber(topic.chapter_section) | |||
There was a problem hiding this comment.
I do sometimes miss java.lang.Comparator
philschatz
added a commit
that referenced
this pull request
Jul 29, 2015
Sort HW builder's chapter sections so they appear in order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.