Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable continue button when saving #683

Merged
merged 1 commit into from
Aug 22, 2015

Conversation

nathanstitt
Copy link
Member

A task step should not be continued while it's state is saving or
loading. The earlier code was checking the isSaving state, but wasn't
passing it onto the AsyncButton.

This should prevent the sequence that occurs occasionally where:

  1. user clicks on a choice
    • An async save is initiated, but due to network conditions, phase of the moon, etc. it's delayed
  2. a short time later, user clicks continue button
    • A async save to mark step completed is sent.
    • Due to the save from step 1 being delayed this arrives before the answer is recorded.
  3. Server error occurs.

With this code, the continue button will be disabled until each network request completes, which will disallow further network requests to be initiated.

A task step should not be continued while it's state is saving or
loading. The earlier code was checking the isSaving state, but wasn't
passing it onto the AsyncButton.
pandafulmanda added a commit that referenced this pull request Aug 22, 2015
@pandafulmanda pandafulmanda merged commit f461da4 into master Aug 22, 2015
@pandafulmanda pandafulmanda deleted the fix/disable-btn-while-saving branch August 22, 2015 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants