Scroll window down so targeted elements are not hidden beneath navbar #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -16,6 +17,10 @@ MEDIA_LINK_EXCLUDES = [ | |||
| '[data-targeted=media]' | |||
| ] | |||
|
|
|||
| # elements that are currently targeted by the URL's hash are | |||
| # scrolled down this much in order to appear below the top navbar | |||
| FOCUSED_TARGET_TOP_POSITION = 100 | |||
There was a problem hiding this comment.
Is this variable still used?
|
How difficult would it be to update the hash when clicking on a link? and have you tested with links to other pages? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After chatting with @pandafulmanda and @Fredasaurus they were in favor of a smooth scroll effect to navigate to elements. This may be completely deprecated by @pandafulmanda's #725 but there may also be times where we want to smoothly scroll to an element.
The gif doesn't really have enough frames to capture the smoooothness:
