Media Previewer #767
Merged
Media Previewer #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… self positioning, image re-positioning, and scrollable height setting
…t only content links get processed, as opposed to footer links as well, clean up prop names
|
|
||
| highlightMedia: -> | ||
| {mediaDOMOnParent} = @props | ||
| mediaDOMOnParent.classList.add('target') |
There was a problem hiding this comment.
Minor: Can this be something like link-target? The term target is already used in other parts of the code (but not CSS) to describe other things
…it's linker, handle multiple images in tutor-popover, minor clean up
…erflow as well for tutor-popover
… tests so then i did that wierd function = null thing on componentWillUnmount, but that doesn't seem necessary anymore, so yay!
…ive for travis push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combo #725 and #756
Media/link viewer
The jumping links was driving me straight up nuts
addresses #758
To do
Table preview
If media is not even on the current page
links externally to ref book, but shows preview on hover
If media is not visible/partially visible
If media is more than half visible
For table, if partially visible
Scrollable inner content, esp useful for big tables
Scrollable for figures as well
Is smart about where to open up viewer
opens to the left when too close to the right
preview for figure in another module/page/whatever
in both iReading and Ref Book
Does not link externally in iReading
Does link externally in reference book view
Even makes the moving man in an interactive step
look cooler
With image loading state