-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Period enrollment code #704
Conversation
id: course.id.to_s, | ||
name: course.profile.name, | ||
periods: [{ id: zeroth_period.id.to_s, name: zeroth_period.name }, | ||
{ id: period.id.to_s, name: period.name }], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the similar tests above were updated because instead of adding in the period information to every single one, it seemed better to remove information from each test that was already tested the first time around, and leave only the part that's in question for the test.
|
||
reversible do |dir| | ||
dir.up do | ||
CourseMembership::Models::Period.where(enrollment_code: nil).find_each do |period| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for find_each
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chalk it up to habit :)
No description provided.