Allow higher priority dictionaries to delete entries from others #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
If there's an entry
{plover:deleted}in a dictionary, Plover will understand that the entry is deleted.TODO: currently reverse-lookup still lists the deleted entry.I've seen the POC in the linked issue, but it has a lot of merge conflicts, it's more complex (edits a lot of places in the code to special-case handle it), it doesn't work well with the add translation dialog (by default it does nothing if either field is empty) and it doesn't seem to work.
The particular entry used to mark deletion can be easily changed. Also it only works if it's the only thing in the stroke.
=deleted(similar to the existing=undosyntax)?Currently it's case-insensitive.
Also, this means there can't be any plugin that defines a command "deleted".
Closes #726 .
Pull Request Checklist