Add icon and tooltip for mapillary detected billboards

openstreetmap · Dec 11, 2019 · 0b7d5b2 · 0b7d5b2
1 parent 70e96fa
commit 0b7d5b2
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/data/core.yaml b/data/core.yaml
@@ -1085,6 +1085,7 @@ en:
       banner: banner
       bench: bench
       bike_rack: bike rack
+      billboard: billboard
       catch_basin: catch basin
       cctv_camera: CCTV camera
       fire_hydrant: fire hydrant

diff --git a/dist/locales/en.json b/dist/locales/en.json
@@ -1362,6 +1362,7 @@
                 "banner": "banner",
                 "bench": "bench",
                 "bike_rack": "bike rack",
+                "billboard": "billboard",
                 "catch_basin": "catch basin",
                 "cctv_camera": "CCTV camera",
                 "fire_hydrant": "fire hydrant",

diff --git a/modules/svg/mapillary_map_features.js b/modules/svg/mapillary_map_features.js
@@ -112,7 +112,13 @@ export function svgMapillaryMapFeatures(projection, context, dispatch) {
             .attr('height', '24px')
             .attr('x', '-12px')
             .attr('y', '-12px')
-            .attr('xlink:href', function(d) { return '#' + d.value; });
+            .attr('xlink:href', function(d) {
+                if (d.value === 'object--billboard') {
+                    // no billboard icon right now, so use the advertisement icon
+                    return '#object--sign--advertisement';
+                }
+                return '#' + d.value;
+            });
 
         enter
             .append('rect')