Skip to content

Commit

Permalink
preserve rows with empty tag values in raw tag editor (#10151)
Browse files Browse the repository at this point in the history
  • Loading branch information
Asif-Sheriff committed Mar 15, 2024
1 parent 6f0e87e commit 1683313
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ _Breaking developer changes, which may affect downstream projects or sites that
#### :tada: New Features
* Add button to fully load incompletely downloaded relations ([#5420])
#### :sparkles: Usability & Accessibility
* Preserve rows with empty tag values in raw tag editor ([#10145], thanks [@Asif-Sheriff])
#### :scissors: Operations
#### :camera: Street-Level
* Show Mapillary username and deep link to external viewer on Mapillary photos ([#10135], thanks [@Sushil642])
Expand All @@ -59,8 +60,10 @@ _Breaking developer changes, which may affect downstream projects or sites that
[#8415]: https://github.com/openstreetmap/iD/issues/8415
[#9439]: https://github.com/openstreetmap/iD/issues/9439
[#10135]: https://github.com/openstreetmap/iD/issues/10135
[#10145]: https://github.com/openstreetmap/iD/issues/10145
[@Sushil642]: https://github.com/Sushil642
[@mattiapezzotti]: https://github.com/mattiapezzotti
[@Asif-Sheriff]: https://github.com/Asif-Sheriff


# 2.28.1
Expand Down
3 changes: 0 additions & 3 deletions modules/ui/sections/raw_tag_editor.js
Original file line number Diff line number Diff line change
Expand Up @@ -558,9 +558,6 @@ export function uiSectionRawTagEditor(id, context) {
// exit if this is a multiselection and no value was entered
if (typeof d.value !== 'string' && !this.value) return;

// remove tag if it is now empty
if (!this.value.trim()) return removeTag(d3_event, d);

// exit if we are currently about to delete this row anyway - #6366
if (_pendingChange && _pendingChange.hasOwnProperty(d.key) && _pendingChange[d.key] === undefined) return;

Expand Down

0 comments on commit 1683313

Please sign in to comment.