Allow movement of any node that is in the selectedIDs list..

(closes #3195)
openstreetmap · Jul 25, 2016 · 2450782 · 2450782
1 parent f4979db
commit 2450782
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/modules/actions/move.js b/modules/actions/move.js
@@ -19,18 +19,22 @@ export function Move(moveIds, tryDelta, projection, cache) {
 
     function setupCache(graph) {
         function canMove(nodeId) {
+            // Allow movement of any node that is in the selectedIDs list..
+            if (moveIds.indexOf(nodeId) !== -1) return true;
+
+            // Allow movement of a vertex where 2 ways meet..
             var parents = _.map(graph.parentWays(graph.entity(nodeId)), 'id');
             if (parents.length < 3) return true;
 
-            // Don't move a vertex where >2 ways meet, unless all parentWays are moving too..
+            // Restrict movement of a vertex where >2 ways meet, unless all parentWays are moving too..
             var parentsMoving = _.every(parents, function(id) { return cache.moving[id]; });
             if (!parentsMoving) delete cache.moving[nodeId];
 
             return parentsMoving;
         }
 
         function cacheEntities(ids) {
-            _.each(ids, function(id) {
+            ids.forEach(function(id) {
                 if (cache.moving[id]) return;
                 cache.moving[id] = true;
 
@@ -44,17 +48,20 @@ export function Move(moveIds, tryDelta, projection, cache) {
                     cache.ways.push(id);
                     cacheEntities(entity.nodes);
                 } else {
-                    cacheEntities(_.map(entity.members, 'id'));
+                    cacheEntities(entity.members.map(function(member) {
+                        return member.id;
+                    }));
                 }
             });
         }
 
         function cacheIntersections(ids) {
             function isEndpoint(way, id) { return !way.isClosed() && !!way.affix(id); }
 
-            _.each(ids, function(id) {
+            ids.forEach(function(id) {
                 // consider only intersections with 1 moved and 1 unmoved way.
-                _.each(graph.childNodes(graph.entity(id)), function(node) {
+                var childNodes = graph.childNodes(graph.entity(id));
+                childNodes.forEach(function(node) {
                     var parents = graph.parentWays(node);
                     if (parents.length !== 2) return;