Add validation warning for "fixme" tags (close #6214)

css/80_app.css

@@ -3366,10 +3366,6 @@ button.autofix.action.active {
     padding-left: 10px;
 }
 
-.entity-issues .issue-container.active .issue-label {
-    border-bottom: 1px solid;
-    border-color: inherit;
-}
 .entity-issues .issue-container.active .issue-label .issue-text {
     font-weight: bold;
 }
@@ -3387,6 +3383,14 @@ button.autofix.action.active {
 }
 
 /* fixes */
+.entity-issues .issue-fix-list {
+    border-top: 1px solid;
+    border-color: inherit;
+}
+.entity-issues .issue-container.active .issue-fix-list:empty {
+    display: none;
+}
+
 li.issue-fix-item {
     padding: 2px 10px 2px 20px;
 }

data/core.yaml

@@ -1348,6 +1348,11 @@ en:
       highway:
         message: "{highway} is disconnected from other roads and paths"
         reference: "Highways should connect to other highways or building entrances."
+    fixme_tag:
+      title: '"Fix Me" Requests'
+      message: '{feature} has a "Fix Me" request'
+      tip: 'Find features with "fixme" tags'
+      reference: 'A "fixme" tag indicates that a mapper has requested help with a feature.'
     generic_name:
       title: Suspicious Names
       message: '{feature} has the suspicious name "{name}"'

dist/locales/en.json

@@ -1665,6 +1665,12 @@
                     "reference": "Highways should connect to other highways or building entrances."
                 }
             },
+            "fixme_tag": {
+                "title": "\"Fix Me\" Requests",
+                "message": "{feature} has a \"Fix Me\" request",
+                "tip": "Find features with \"fixme\" tags",
+                "reference": "A \"fixme\" tag indicates that a mapper has requested help with a feature."
+            },
             "generic_name": {
                 "title": "Suspicious Names",
                 "message": "{feature} has the suspicious name \"{name}\"",

modules/validations/fixme_tag.js

@@ -0,0 +1,44 @@
+import { t } from '../util/locale';
+import { utilDisplayLabel } from '../util';
+import { validationIssue } from '../core/validation';
+
+
+export function validationFixmeTag() {
+    var type = 'fixme_tag';
+
+
+    var validation = function checkFixmeTag(entity, context) {
+
+        if (!entity.tags.fixme) return [];
+
+        // don't flag fixmes on features added by the user
+        if (entity.version === undefined) return [];
+
+        if (entity.v !== undefined) {
+            var baseEntity = context.history().base().hasEntity(entity.id);
+            // don't flag fixmes added by the user on existing features
+            if (!baseEntity || !baseEntity.tags.fixme) return [];
+        }
+
+        return [new validationIssue({
+            type: type,
+            severity: 'warning',
+            message: t('issues.fixme_tag.message', { feature: utilDisplayLabel(entity, context) }),
+            reference: showReference,
+            entities: [entity]
+        })];
+
+        function showReference(selection) {
+            selection.selectAll('.issue-reference')
+                .data([0])
+                .enter()
+                .append('div')
+                .attr('class', 'issue-reference')
+                .text(t('issues.fixme_tag.reference'));
+        }
+    };
+
+    validation.type = type;
+
+    return validation;
+}

modules/validations/index.js

@@ -1,6 +1,7 @@
 export { validationAlmostJunction } from './almost_junction';
 export { validationCrossingWays } from './crossing_ways';
 export { validationDisconnectedWay } from './disconnected_way';
+export { validationFixmeTag } from './fixme_tag';
 export { validationGenericName } from './generic_name';
 export { validationIncompatibleSource } from './incompatible_source';
 export { validationMaprules } from './maprules';