Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oneway=reversible is displayed with oneway=yes direction arrows #4291

Closed
artischocke opened this issue Aug 28, 2017 · 5 comments
Closed

oneway=reversible is displayed with oneway=yes direction arrows #4291

artischocke opened this issue Aug 28, 2017 · 5 comments
Labels
map-renderer An issue with how things are rendered in the map

Comments

@artischocke
Copy link

artischocke commented Aug 28, 2017

image

The I-595 Express Lanes in Ft. Lauderdale change direction depending on the time of day, and are therefore tagged with oneway=reversible. I'd expect these ways to be displayed with no direction arrows (or, if anything, arrows in both directions perhaps), but they're displayed with one-way arrows instead.

E.g. https://www.openstreetmap.org/way/332703663

Edit: it would probably make sense to apply the same rendering to oneway=alternating as well

@JamesKingdom JamesKingdom added the map-renderer An issue with how things are rendered in the map label Aug 28, 2017
@boothym
Copy link
Contributor

boothym commented Aug 28, 2017

if anything, arrows in both directions perhaps

That sounds like a good idea, though perhaps with smaller arrows

@artischocke
Copy link
Author

Whatever the rendering, perhaps it would be a good time to add support for oneway=alternating as well by applying the same rendering.

@bhousel bhousel added the good first issue Best for first-time contributors. No experience necessary! label Sep 18, 2017
@bhousel bhousel added help wanted For intermediate contributors, requires investigation or knowledge of iD code and removed good first issue Best for first-time contributors. No experience necessary! labels Oct 12, 2017
@bhousel bhousel closed this as completed in c908807 Jan 4, 2018
@bhousel
Copy link
Member

bhousel commented Jan 4, 2018

I did this today.. We'll now render oneway=alternating and oneway=reversible with dual arrowheads, and added those extra options to cycle through when using the oneway checkbox:

reversible oneways

(I know it is weird to cycle through more options than yes/no on a checkbox, but whatever, it already had 3 states)

@bhousel
Copy link
Member

bhousel commented Jan 4, 2018

I also changed the checkbox field to display non-standard values (other than 'yes'/'no') in the field label. These are hopefully rare but obviously anything can happen in OSM.

Before:

The box would render as unchecked.
screenshot 2018-01-04 13 49 45

After:

The box is checked and the "value" appears in quotes.
screenshot 2018-01-04 13 48 58

@bhousel bhousel removed the help wanted For intermediate contributors, requires investigation or knowledge of iD code label Jan 4, 2018
@iandees
Copy link
Collaborator

iandees commented Jan 4, 2018

https://www.urbandictionary.com/define.php?term=lit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
map-renderer An issue with how things are rendered in the map
Projects
None yet
Development

No branches or pull requests

5 participants