Unneccesary underscores added to source

[hikemaniac]

When writing a changeset comment and adding a source, iD will automatically add underscores to the source tag. I believe that this is actually an unneccesary feature; most editors (e.g.: JOSM) will apply the source tag without the underscores and the wiki says nothing about it. As this is bad for the readability, can we remove this feature?

[bhousel]

Thanks for reporting, I agree..

[octagonal]

I'll have a look

[bhousel]

@octagonal this is an easy one!

• open data/presets/fields/source.json
• add the property "snake_case": false
• npm run build

This should tell iD to not stick underscores in the value for this field.

[octagonal]

Thanks @bhousel! This is a really delightful app though, I'm glad I came across it!
Do you have any other good first issue type issues?

[bhousel]

Thanks @bhousel! This is a really delightful app though, I'm glad I came across it!
Do you have any other good first issue type issues?

Thanks for the kind words @octagonal!

With Hacktoberfest going on, people tend to close the good first issues really quickly. Most of the issues involving "presets" are fairly straightforward, because the presets in iD are just stored in .json files. If you are following the project you will see a few of these appear every week. I'll add some info to #4441 and you can do that one!

Another great thing to do would be to visit https://openstreetmap.org and do some mapping with the iD editor. Find a place on OpenStreetMap that you are familiar with, click "Edit", go through the tutorial, and start improving the map around there. You can also visit http://tasks.hotosm.org/ if you want to work on mapping for a humanitarian purpose. You won't get Hacktoberfest credit, but it's a great way to get familiar with the editor, if getting deeper into the code is something you are interested in! We'd love the help ❤️

[octagonal]

@bhousel thanks for the pointers on how to get started! I'll have a look at #4441 this weekend.

if getting deeper into the code is something you are interested in!

I am indeed. Especially the map display and tooling part seems like a fun and challenging problem space. (Just for reference, I have a few years of coding experience and want to start contributing much more to open source projects 😄)