Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace alert box with modal ui #4806

Closed
jidanni opened this issue Feb 15, 2018 · 8 comments
Closed

Replace alert box with modal ui #4806

jidanni opened this issue Feb 15, 2018 · 8 comments
Assignees
Labels
bug-browser-specific A bug that only appears in certain browsers

Comments

@jidanni
Copy link
Contributor

jidanni commented Feb 15, 2018

Allow copying the example (switch...) in
1
in fact allow copying the whole thing.
As it is currently, the user can't even do Inspect Element on it.

@bhousel
Copy link
Member

bhousel commented Feb 15, 2018

All the normal window stuff like select/copy/paste works fine here for me (in chrome 64)... What else have you tried? Are you sure this is a real issue?

copy alert text

@bhousel bhousel added the bug-cant-reproduce Having trouble reproducing this issue label Feb 15, 2018
@jidanni
Copy link
Contributor Author

jidanni commented Feb 15, 2018

I can do like you in Firefox.
I can copy the text mentioned in
https://bugs.chromium.org/p/chromium/issues/detail?id=5879

But, with

Package: chromium
Version: 64.0.3282.119-2
Kernel: Linux 4.14.0-3-amd64 (SMP w/2 CPU cores)

the pointer remains an arrow over the entire box.
There is no right context menu.

@bhousel
Copy link
Member

bhousel commented Feb 15, 2018

It sounds like a browser bug outside of our control.

If we swap out the window.prompt for a custom modal, as described here, #4802 (comment) then we wouldn't be relying on the browser behavior and this issue would go away.

@bhousel bhousel added bug-browser-specific A bug that only appears in certain browsers and removed bug-cant-reproduce Having trouble reproducing this issue labels Feb 15, 2018
@jidanni
Copy link
Contributor Author

jidanni commented Feb 15, 2018

@jidanni
Copy link
Contributor Author

jidanni commented Feb 19, 2018

In https://bugs.chromium.org/p/chromium/issues/detail?id=812644#c6
they say

Could you provide HTML+CSS for alter box?
It seems user-select CSS property prevents to select contents in alter box
except for text box.

@bhousel
Copy link
Member

bhousel commented Feb 19, 2018

In https://bugs.chromium.org/p/chromium/issues/detail?id=812644#c6
they say

You can point them at http://preview.ideditor.com/master as an example..

user-select should not affect the selectability of text in a window.prompt, and I'm using Chrome and I don't see this issue, so it might just be Chrome on Linux that has the issue.

@bhousel
Copy link
Member

bhousel commented Jun 29, 2018

Assigned to @vershwal

@bhousel bhousel changed the title Allow copying the example Replace alert box with modal ui Jun 29, 2018
@bhousel
Copy link
Member

bhousel commented Aug 11, 2018

This was done in #5207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-browser-specific A bug that only appears in certain browsers
Projects
None yet
Development

No branches or pull requests

3 participants