Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preset for dancing school #4846

Merged
merged 3 commits into from
Mar 5, 2018
Merged

Add preset for dancing school #4846

merged 3 commits into from
Mar 5, 2018

Conversation

hikemaniac
Copy link
Contributor

@hikemaniac hikemaniac commented Mar 4, 2018

This PR adds a preset for leisure=dance with dance:teaching=yes. On the wiki page dance:teaching=* is described as an additional tag, telling that "dancers can obtain tuition". dance:teaching currently has over 700 uses. Would you accept this tagging scheme and review the structure?

@bhousel
Copy link
Member

bhousel commented Mar 5, 2018

This PR adds a preset for leisure=dance with dance:teaching=yes. On the wiki page dance:teaching=* is described as an additional tag, telling that "dancers can obtain tuition". dance:teaching currently has over 700 uses. Would you accept this tagging scheme and review the structure?

Looks good to me.. I'm going to change the icon so it looks more musical and less like a school with pencils and rulers. I'll also add the field so that users can say what kind of dance they teach there.

@bhousel bhousel merged commit 05c9f49 into openstreetmap:master Mar 5, 2018
bhousel added a commit that referenced this pull request Mar 5, 2018
@hikemaniac hikemaniac deleted the dancing_school branch March 5, 2018 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants