Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lines from custom data files block clicking ways underneath them #5257

Closed
JesseCrocker opened this issue Aug 27, 2018 · 16 comments · Fixed by #5479
Closed

Lines from custom data files block clicking ways underneath them #5257

JesseCrocker opened this issue Aug 27, 2018 · 16 comments · Fixed by #5479
Labels
bug A bug - let's fix this!

Comments

@JesseCrocker
Copy link

Im tracing trails from gpx files. When a node from an existing way is under a line from a gpx file it is not possible to select the node when making a new way.

This is a regression in 2.11.0

@bhousel
Copy link
Member

bhousel commented Aug 29, 2018

Yep, you might just have to zoom in more until the data is not exactly on top of whatever is already there. The external data files are selectable now, so they'll steal your clicks.

@bhousel bhousel added the considering Not Actionable - still considering if this is something we want label Aug 29, 2018
@JesseCrocker
Copy link
Author

Yeah, thats whats happening, gpx line is stealing clicks. It seems weird that the line is selectable, because it doesnt seem like you can do anything with it after selecting. But this might just be a case where im seeing this as a bug because it breaks my particular workflow.

@tkansgar
Copy link

Hi all,

this new feature is very annoying for me. Sometimes the point I want to click, is really so exakt under the gpx line, that almost whatever zoom level I try, it's not possible to hit the point instead of the gpx line. My proposal is to give a higher sensitivity level to the points of lines than to the gpx lines. The point should get precedence over the gpx line, if both are close together. Is this realisable?

Best regards
tkansgar

@njohnston
Copy link

Just to provide some more user input, this change has drastically slowed down my mapping, and caused me to accidentally not connect some paths correctly (since the ends of lines don't "snap" to nodes on other ways as easily if there's a nearby track).

For example, when editing with this sample GPX file, selecting the node I've marked in red is tricky:

image

I need to zoom in several times and then click around, aiming very carefully.

I agree with @JesseCrocker: having tracks from GPX files selectable doesn't seem to add any value, except for the marginal benefit of being able to identify different segments/tracks from the same file.

I've had the same problem as @tkansgar when trying to add nodes for stiles and gates to a footpath. While out surveying, I added waypoints/markers for the stiles and gates, but I can't actually add the corresponding nodes in the same locations.

In cases like these, where a track/trace intersects an existing OpenStreetMap way, it's impossible to select the actual point at where the track/trace and way intersect, regardless of zoom:

image

@tkansgar
Copy link

tkansgar commented Sep 1, 2018

Hi all again,

I found a second workaround (the first one is zooming in): You can switch off the gpx line temporarily. Display the panel "map data" (hope this is the correct name in english) on the right side and uncheck the setting "user defined map data". The gpx line is gone, and you can make your changes. Then switch on the "user defined map data" to see the gpx line again.

But better than any workaround would it be, if the gpx line would get a lower click precedence than the OSM data, as I wrote before.

Br
tkansgar

@Mahabarata
Copy link

Mahabarata commented Sep 1, 2018

Very good your second workaround.
But I hope this bug will be fixed soon, very annoying and make lose a lot of time.
Why this issue is not marked "bug" ?
Because the comment of "bhousel" doesn't work : with a GPS, I was on a road then I turned to the left to another road. I see with my GPX track that the second road was not at the good place (I think build with some satellite view, all was too much on the left). But the point of the intersection was exactely under the GPX track : even when zooming, impossible to select the point and move it. So I let the intersection at the bad place (and move a little the other points of the second road to correct their positions). Not a big problem but a true bug.
I cannot understand why is it useful to be able to select the GPX track : for me it's exactely like the satellit view of bing : just need to be in the background and not selectable at all.
But if you really want to continue with that, I suggest to make it able with some keys of the keyboard (like CTRL+SHIFT+click on the track to select the GPX track)
Best regards

@bhousel
Copy link
Member

bhousel commented Sep 1, 2018

Why this issue is not marked "bug" ?

I'm on vacation this week and I'll get to it next week. Anyway yeah I'll mark it as "bug".

Not a big problem

I agree

I cannot understand why is it useful to be able to select the GPX track

There are lots of potential sources of external data (gpx is only one of these). Being able to select and inspect external data is both useful (#5243) and will unblock more interesting things (#2586 #3773 and #4164 are all related).

There is code in iD to determine "what the user actually clicked on" and it really depends on what order we draw things into the SVG DOM. The OSM objects in iD (points, lines, areas, midpoints, vertices) all draw invisible touch targets to grab the mouse clicks, so we can control exactly what gets clicked. The OSM Notes, Data (gpx) and upcoming KeepRight layers don't do this yet and are instead just drawn on top of whatever is there, that's why they steal the clicks. It's actually not a difficult problem to solve, it just requires some reworking of the layer draw order.

In the mean time, just zoom in and put your point next to where the gpx track is. Your gpx track is not super accurate anyway, and it's totally ok to just put the point a few centimeters away from where it's actually drawn on the screen.

I'm sorry that it slows you down while editing, and I do understand that it can be frustrating when the developers change some feature of software that you use regularly. If you really want to be the fastest mapper you can be, it's probably worth your time to install JOSM and get a gaming mouse.

@bhousel bhousel added bug A bug - let's fix this! and removed considering Not Actionable - still considering if this is something we want labels Sep 1, 2018
@Mahabarata
Copy link

Mahabarata commented Sep 2, 2018 via email

@HarelM
Copy link

HarelM commented Oct 9, 2018

Any updates on this? I agree this slows the tracing process for me as well.

@jeffrey-friedl
Copy link

There are lots of potential sources of external data (gpx is only one of these). Being able to select and inspect external data is both useful (#5243) and will unblock more interesting things (#2586 #3773 and #4164 are all related).

Is it possible to make selectability an option, just as one can optionally show or hide the whole thing?

@tordans
Copy link
Collaborator

tordans commented Oct 10, 2018

I wonder if there could be a button in the left-panel.

Workflow example:

  1. I show a gpx
  2. I click it => the left-panel shows info about it
  3. There is a button "Prevent interaction with this"
  4. I click the button => The gpx is now non-selectable until … (I reload, I save, …)

@Mahabarata
Copy link

Mahabarata commented Oct 10, 2018 via email

@bhousel
Copy link
Member

bhousel commented Nov 12, 2018

This was done! the OSM objects now take precedence over the non-OSM objects.

@tkansgar
Copy link

Hi Bryan,

is the version with this fix already working on openstreetmap.org? I can't notice any change there in behaviour.

Best regards
tkansgar

@bhousel
Copy link
Member

bhousel commented Nov 21, 2018

is the version with this fix already working on openstreetmap.org? I can't notice any change there in behaviour.

It is not yet..

@Mahabarata
Copy link

Hi,
sorry to come back here but there is still a pb : here with an example.
When you select a way then create a new node on that way or select an existing one, if you move the node on the gpx (to improve the way), on the left you lost the informations about the way and you have informations about the gpx file.

In this picture you can clearly see that the way is selected (there is like an aura around it, not easy to capture it because it flashes) but on the left you have lost the information of the way. The gpx is no more selected on the right which is great but on the left ID works as it was.
Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants