Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer adjustments #5479

Merged
merged 6 commits into from
Nov 12, 2018
Merged

Layer adjustments #5479

merged 6 commits into from
Nov 12, 2018

Conversation

bhousel
Copy link
Member

@bhousel bhousel commented Nov 10, 2018

This adjusts the stacking order so that the interactive OSM objects take precedence over the interactive non-OSM objects.

fixes #5257

Still need to test a bit more..

@bhousel
Copy link
Member Author

bhousel commented Nov 12, 2018

This is good enough for now.

I did also attempt to remove the supersurface and instead set separate transforms for each layer, but doing it that way ended up being worse for performance.

If each layer could have a separate transform, they could render during async idle callback, instead of all together on the main thread.

I dug a bit into performance and there are big issues with style recalculation and repainting that I have no idea how to fix. 😞

screenshot 2018-11-12 15 01 34

@bhousel bhousel merged commit f8d67e8 into master Nov 12, 2018
@bhousel bhousel deleted the layer-adjustments branch November 12, 2018 20:05
@iandees
Copy link
Collaborator

iandees commented Nov 12, 2018

Maybe it's ...

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lines from custom data files block clicking ways underneath them
2 participants