Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Use different layers" warning not clear #5943

Closed
mmd-osm opened this issue Feb 23, 2019 · 2 comments
Closed

"Use different layers" warning not clear #5943

mmd-osm opened this issue Feb 23, 2019 · 2 comments
Assignees
Labels
validation An issue with the validation or Q/A code
Milestone

Comments

@mmd-osm
Copy link
Contributor

mmd-osm commented Feb 23, 2019

This might be an example where reusing icons for different purposes hurts usability. Both the "Background settings" icon in the right panel, and the "Use different layers" warning share the same icon. Both of them talk about some "layers", but essentially they mean quite different things. The one talks about image layers, the other about adding/changing some layer tag to/on an existing object (at least that's what I assumed).

layer1

layer2

Unfortunately, there's no indication as to what a "layer" is supposed to be in this context. The UI lists a "levels" tag further down in the list, which again is some different concept:

layer3

Overall, the UI gives me no indication on how to proceed, and how to fix that warning.

In case of two overlapping buildings. the wiki suggests to use the level=* key instead (according to the "Simple Indoor Tagging"). However, the validator isn't aware of this level=* tag and still reports the same warning.

@kymckay
Copy link
Collaborator

kymckay commented Feb 23, 2019

I think this is where something along the lines of #5900 would help

@quincylvania quincylvania added the validation An issue with the validation or Q/A code label Apr 1, 2019
@quincylvania quincylvania self-assigned this Apr 1, 2019
@quincylvania
Copy link
Collaborator

@mmd-osm Thanks for raising this issue, I agree it was somewhat confusing. I replaced the "Use different layers" fix with a pair of fixes where you just tell iD if the selected feature is a higher or lower layer than the other.

An example for crossing tunnels with equivalent layer tags:

Screen Shot 2019-04-01 at 11 53 11 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation An issue with the validation or Q/A code
Projects
None yet
Development

No branches or pull requests

3 participants