Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect offer to add layer to building #7938

Closed
cebderby opened this issue Aug 31, 2020 · 2 comments
Closed

Incorrect offer to add layer to building #7938

cebderby opened this issue Aug 31, 2020 · 2 comments
Labels
validation An issue with the validation or Q/A code wontfix-not-a-bug Not actually a bug

Comments

@cebderby
Copy link

I had noticed a number of cases of inexperienced and poor users adding layer to building, especially where ways (correctly) enter or leave. I note that iD highlights ways crossing buildings and makes a number of 'fix' proposals, including changing layer values.
Layer is not a building tag. It shall not be added to buildings by iD by any automated/semi-automated process.
Layer is used to define the local layering of crossing ways. Not buildings. iD shall not offer to add layer to ways on seeing a way crossing a building boundary. The offers shall be:

  • if the way really enters the building, do nothing
  • if the way is supposed to remain outside/inside, adjust the geometry
  • if the way is a building passage, add tunnel=building_passage
    I note a history of refusing proper suggestions to preserve the integrity of OSM, I hope this will be properly actioned.
@quincylvania
Copy link
Collaborator

Some background on the use of layer in the validator: #5943, #5924, #6367, #7809.

As I understand it, the layer tag simply specifies the vertical ordering of ways when it's ambiguous. I'm not sure what's wrong with using it on buildings… how else would you specify the order when one building physically overlaps another? A tag like building=roof tag is combined with layer over 570,000 times. The iD validator didn't invent this tagging.

While ideally a crossed highway could have info like tunnel, covered, indoor, or bridge, the layer alone is enough to clarify what's going on for renderers and is simple for the typical mapper to add.

That said, we can reevaluate if this is causing issues for data consumers or the community at large decides this isn't correct.

@quincylvania quincylvania added considering Not Actionable - still considering if this is something we want validation An issue with the validation or Q/A code labels Sep 9, 2020
@quincylvania
Copy link
Collaborator

Lacking further discussion, I'm closing this as not-a-bug.

@quincylvania quincylvania added wontfix-not-a-bug Not actually a bug and removed considering Not Actionable - still considering if this is something we want labels Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation An issue with the validation or Q/A code wontfix-not-a-bug Not actually a bug
Projects
None yet
Development

No branches or pull requests

2 participants