Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write validation code documentation #6100

Closed
quincylvania opened this issue Mar 25, 2019 · 2 comments
Closed

Write validation code documentation #6100

quincylvania opened this issue Mar 25, 2019 · 2 comments
Assignees
@quincylvania
Labels
documentation Improvements to the iD documentation
Milestone
2.16.0

Comments

@quincylvania
Copy link
Collaborator

In order to help potential contributors and developers of downstream branches of iD, we should add info on how the validation system works to ARCHITECTURE.md.
@quincylvania quincylvania added the documentation Improvements to the iD documentation label Mar 25, 2019
@bhousel
Copy link
Member

bhousel commented Apr 4, 2019

I'm changing some stuff in #6140, so we can hold off on this

@bhousel bhousel added the waitfor Waiting for something label Apr 4, 2019
@bhousel bhousel removed the waitfor Waiting for something label Apr 23, 2019
@quincylvania quincylvania added this to the 2.16.0 milestone Oct 9, 2019
@quincylvania quincylvania self-assigned this Oct 9, 2019
quincylvania added a commit that referenced this issue Oct 9, 2019
@quincylvania
Start validation documentation (re: #6100)
d578074 
Add subtypes to close_nodes and unsquare_way validations
quincylvania added a commit that referenced this issue Oct 9, 2019
@quincylvania
Rename "Fix Me" Requests validation rule to more general Help Requests
a3d6097 
Add subtypes to almost_junction and disconnected_way validation rules
Add additional validation documentation (re: #6100)
quincylvania added a commit that referenced this issue Oct 9, 2019
@quincylvania
Add documentation about validation issue changeset tags (re: #6100)
19cee51
@quincylvania
Copy link
Collaborator Author

So I added a fair amount about the validation system including issue severities, rules, types, subtypes, and changeset tags. If someone is interested in more details then I'd be happy to write more at a later time.

@bhousel bhousel mentioned this issue Oct 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quincylvania quincylvania

Labels
documentation Improvements to the iD documentation
Projects
None yet
Milestone
2.16.0
Development

No branches or pull requests
2 participants
@bhousel @quincylvania