-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator: "Building crosses" but "building:min_level=1" #6192
Comments
Can you attach also an image? Mapillary is completely broken for me (I reported the bug using their requested method, but from what I see at https://forum.mapillary.com/ it seems that fix is unlikely). |
Thanks! Right, Even |
Well I guess we disagree on that too. |
What exactly does covered mean? Covered from rain, or "something is above this feature" |
@tordans Unfortunately I don't think we can expect every data consumer to interpret We still might need a way to make these easier to fix, but I think that's the idea behind #5924 so I'm going to close this as a duplicate.
@BjornRasmussen I usually consider |
I see this on http://preview.ideditor.com/master/#background=Berlin-2018&disable_features=boundaries&id=w553278769&locale=en&map=19.00/52.47903/13.45192
This is what it looks like in RL https://www.mapillary.com/app/?pKey=ujm1Rwmvxx0bnD9DtnbPVw&focus=photo&lat=52.47894457514562&lng=13.451897309587071&z=17.
The building is
building:min_level=1
which basically makes it "fly" above a street. https://wiki.openstreetmap.org/wiki/Key:building:min_levelIMO the message is not ideal ATM.
Some thoughts to improve it:
If the part covering the street is not very big (like in my example), the validator could just ignore the place IMO; at least for now.
The suggested "tunnel" and "bridge" are IMO both wrong whenever the validated object is a
building=* + building:min_level=*
. At least that is, how I read most of https://wiki.openstreetmap.org/wiki/Key:covered. There is one part that gives me pause and suggests that "tunnel=building_passage" is a better fit, even in this situation (my example is not open to one side).So depending on how we read the wiki, it should suggest
covered=yes
ortunnel=building_passage
– or maybe both, with explanation to which should be used.(Or something like this.)
This tickets is very similar to #5891. Maybe the one-click-split action could at be available if the geometry is simple enough (like in my example above)?
The text was updated successfully, but these errors were encountered: