-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn if feature mismatches because of geometry #6319
Comments
Yes, I agree it would be good to warn about situations like this. |
I'm thinking we can make this validation part of "Lines Tagged as Areas" and give it a better name like "Mismatched Geometry". |
@quincylvania this looks great. I wonder, might this be a case for the "Extract" Action as a second link-action (next to the "Ignore this issue")? From the initial example by matkoniecz at https://preview.ideditor.com/master/#background=Maxar-Premium&disable_features=boundaries&locale=en&map=19.00/36.70793/4.03434&node=2065667950 the extract would be a good way to solve the issue. |
Yep, good suggestion. This is followup work. |
But what is, when the feature has the tags support=wall_mounted and location=outdoor, e. g. a veding machine like this https://www.openstreetmap.org/node/1261048099 ? Isn't it allowed there to make this feature as a member of a building=*-way? I don't understand why it should not. You can add location=outdoor to denote that the feature isn't in the building. |
@Lukas458 These warnings are based on preset tags. If you're seeing an erroneous warning then we can consider updating the geometry types allowed for the preset in question. |
Yes, i think that's what I'd be fine with. I understand sense of those warnings for some presets but still not for vending machines. |
Currently
amenity=bank
node used as a building corner is neither treated as a bank nor triggering a validator warning. Currently it results in a bit confusing handling of this situation.Given that tagging is dubious second is probably preferable.
See https://www.openstreetmap.org/edit?editor=id&node=2065667950#map=19/36.70793/4.03434
Note difference between BNP Paribas bank and Société Générale bank (displayed with a black dot icon).
Obviously, most of features are unsuitable to be used on a nodes of a building area - banks are not unique and warning may be more general.
The text was updated successfully, but these errors were encountered: