Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applying validation fix deletes latest added tag via raw tag editor #6407

Closed
Nakaner opened this issue May 22, 2019 · 3 comments
Closed

Applying validation fix deletes latest added tag via raw tag editor #6407

Nakaner opened this issue May 22, 2019 · 3 comments
Assignees
@bhousel
Labels
bug A bug - let's fix this!
Milestone
2.15.1

Comments

@Nakaner
Copy link

Nakaner commented May 22, 2019 •
edited

To reproduce:

  • Open iD.
  • Create a new point, select the basic preset "Point".
  • Open raw tag editor.
  • Add amenity=dentist.
  • Add name=Test (or any other string as name).
  • optional (does not have any influence on behaviour): Press tab, enter or click into any input field of the doctor preset (e.g. opening hours)
  • Validation warning pops up, click on "update properties".
  • The name disappears from raw tag list. This is the bug.

It happens with some other tags (description, note, …) as well but I haven't figured out which.

Firefox 66.0.5 amd64 for Ubuntu 16.04
@quincylvania quincylvania added the bug A bug - let's fix this! label May 22, 2019
@bhousel bhousel self-assigned this May 22, 2019
bhousel added a commit that referenced this issue May 23, 2019
@bhousel
Need issue id to actually change for d3 to replace it
5b8db55 
(re: #6407)

What's happening here is that the validator is updating the issues, but the
entity_issues component leaves the original issue in the list because the `id`
has not changed.

Need to review all the validators to see if others have this problem too.
@bhousel bhousel added the wip Work in progress label May 23, 2019
@bhousel
Copy link
Member

bhousel commented May 23, 2019

Thanks for reporting @Nakaner .. I've pushed a fix which should resolve the problem for this validation rule, but I'm going to check all the rules to see whether others would have the same problem.

@bhousel bhousel mentioned this issue May 23, 2019
Closed
bhousel added a commit that referenced this issue May 23, 2019
@bhousel
Use latest entity at time of fix for private_data validation too
149a0b4 
(re: #6407)
@bhousel
Copy link
Member

bhousel commented May 23, 2019

This was done! For a few rules which manipulated tags, we needed to make sure to use the current tags at time of fix, not reuse previous tags at time of detection.

@bhousel bhousel closed this as completed May 23, 2019
@bhousel
Copy link
Member

bhousel commented May 23, 2019

This was done! For a few rules which manipulated tags, we needed to make sure to use the current tags at time of fix, not reuse previous tags at time of detection.

149a0b4 2019-05-23 Use latest entity at time of fix for private_data validation too
5440467 2019-05-23 Undo 5b8db55 and instead get latest entity at time of fix

@bhousel bhousel removed the wip Work in progress label May 23, 2019
@quincylvania quincylvania added this to the 2.15.1 milestone May 24, 2019
@bhousel bhousel mentioned this issue May 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhousel bhousel

Labels
bug A bug - let's fix this!
Projects
None yet
Milestone
2.15.1
Development

No branches or pull requests
3 participants
@bhousel @quincylvania @Nakaner