Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawing segment type toolbar item #6453

Closed
quincylvania opened this issue May 29, 2019 · 4 comments
Closed

Drawing segment type toolbar item #6453

quincylvania opened this issue May 29, 2019 · 4 comments
Labels
tools Something for the taskbar/toolbar

Comments

@quincylvania
Copy link
Collaborator

Breaking this off from #5960: we should have a toolbar item while drawing to switch between normal (straight) and orthogonal drawing. The user could switch between them while drawing a feature, with the orthogonal segment relative to the previous segment. This would work for both lines and areas. See also #2699.

Screen Shot 2019-05-29 at 10 03 48 AM

@quincylvania quincylvania added the tools Something for the taskbar/toolbar label May 29, 2019
@quincylvania
Copy link
Collaborator Author

I did this! The orthogonal drawing is fairly primitive, but it gives us a place to start from. We should target the functionality shown in #2699.

ortho segments demo

@BjornRasmussen
Copy link
Contributor

This is AMAZING! I just tried it out on preview.ideditor.com/master and love it!
I do have couple of suggestions, though:

  • allow for 45, 30, & 60 degree angles:
    JOSM looks like this:
    Screenshot from 2019-05-29 12-19-16
  • snap to places where a previously added node in the way is 90 degrees to the right or left.
    JOSM looks like this:
    image
    this makes it easier to end a way as a squared shape.

@BjornRasmussen
Copy link
Contributor

BjornRasmussen commented May 29, 2019

JOSM also has a quick way to switch between the two drawing modes: pressing the keyboard shortcut A. This might also make sense in iD, since I find myself switching between the two modes a lot.

@quincylvania
Copy link
Collaborator Author

JOSM also has a quick way to switch between the two drawing modes: pressing the keyboard shortcut A. This might also make sense in iD, since I find myself switching between the two modes a lot.

I was considering either this or a different shortcut for each segment type, since we'll eventually have a circular type as well. I guess a single shortcut is fine since there should never be too many options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Something for the taskbar/toolbar
Projects
None yet
Development

No branches or pull requests

2 participants