Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields for presets from "moreFields" get removed when editing #6580

Closed
BjornRasmussen opened this issue Jun 25, 2019 · 0 comments
Closed

Fields for presets from "moreFields" get removed when editing #6580

BjornRasmussen opened this issue Jun 25, 2019 · 0 comments
Assignees
Labels
bug A bug - let's fix this!
Milestone

Comments

@BjornRasmussen
Copy link
Contributor

Whenever the tags of an object change, the fields are updated on the spot. This means that when a checkbox that usually is found in the more fields section gets checked to the "unknown" value, it disappears. This also happens with several other fields that are only shown through the "add field" section then they are set to blank.

To reproduce:

  1. Select an existing object that has a field filled out that usually only appears when added through the Add More Information section.
  2. Set the field to the default state (the one that doesn't add any tags to the object).
  3. The field will instantly disappear, making further editing of the field impossible without reapplying it through the Add More Information section.

To fix this, something should be added to the code that regenerates the sidebar when the tags are changed to make sure that it makes all fields that were visible when the object was last selected visible. This is already in place for fields that were just added, so very little code should need to be added to resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

2 participants