Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to iD v2.17.0 #2474

Merged
merged 2 commits into from
Dec 23, 2019
Merged

Update to iD v2.17.0 #2474

merged 2 commits into from
Dec 23, 2019

Conversation

quincylvania
Copy link
Contributor

Preview this release. (Deployment may be delayed, check version number in bottom right)

2.17.0

2019-Dec-23

πŸ“° News

  • We've launched the iD Blog providing news and insights into the project from its maintainers and contributors (#7045)

πŸ“£ Release Highlights

  • πŸš‡ You can now add bridges and tunnels with a single click to fix crossing roads, rails, and waterways. Thanks to @CarycaKatarzyna for working on this!

    Find the "Add a bridge" and "Add a tunnel" fixes for each crossing in the Issues inspector.
  • 🌍 Selected features now stay visible while zoomed out, plus you can zoom to multiple features together.

    Select a few large features and press Z to view their full extent, no matter how vast.
  • 🀝 iD now has its own Privacy Policy.

    Press P to view privacy preferences.

πŸ’₯ Breaking Changes

πŸŽ‰ New Features

  • Display selected features at any zoom level (#2962, #5001)
  • Add Privacy Policy and ability to opt-out of icons loaded from third-party sites (#7040)

✨ Usability

  • Support squaring multiple selected features at the same time (#6565)
  • Support zooming to multiple selected features together with the Z shortcut (#6696)
  • Highlight the members of selected relations in yellow (#5766)
  • Return feature search results from all downloaded data, not just the visible area (#6515)
  • Show results for all three OpenStreetMap entity types when searching an ID without a prefix (#7112)
  • Style hotkeys in tooltips as keyboard keys (#6574)
  • Make the top toolbar horizontally-scrollable at narrow sizes (#6755)
  • Always show the Layer subfield of the Structure field when a value is present (#6911)
  • Disable the Circularize operation if the selected way is already circular (#6816, #6993, thanks @CarycaKatarzyna)
  • Fallback to a preset's vector icon if its image fails to load, e.g. due to content blockers (#7028)
  • Convert single-member multipolygons to basic areas when merging member lines (#5085)
  • Always show the currently selected background in the sources list (#7061)
  • Only show background sources with global coverage at low zooms (#7062)
  • Render features with a status-prefix tags with a dashed style, e.g. demolished:building=yes
  • Add tooltips to Mapillary Map Features overlay icons (#7079)
  • Add button to manually retry connecting to the OpenStreetMap API upon a failure (#6650)
  • Clarify the OpenStreetMap API connection failure message (#7021)
  • Improve styling of points linked to Wikidata
  • Render landuse=village_green areas in green (#7011)
  • Render Putting Greens and similar features in light green (#7101)

βœ… Validation

  • For crossing ways issues, offer one-click "Add a bridge" and "Add a tunnel" fixes (#6617, #7055, thanks @CarycaKatarzyna)
  • For crossing way-building issues, offer one-click fixes that set higher or lower layers (#5924, #6911)
  • Flag unclosed multipolgon parts (#2223)
  • Flag crossing and one-way issues for features with waterway=fish_pass
  • Don't suggest upgrading to brands that don't exist in the feature's country (#6513, #6479)
  • Don't flag very close points with differing house or unit numbers (#6998)
  • Allow the not:brand:wikidata tag to silence nonstandard brand warnings (#6577)
  • Include default field values when upgrading to a preset with a specific replacement (#7033)
  • Add tooltips to some disabled fix buttons
  • Don't flag natural=cape or amenity=vending_machine on vertices as mismatched geometry (#6982, #6515)
  • Don't add oneway=yes to highway=motorway_link by default (#7013)
  • Don't expect an arbitrary junction tag to imply a feature should be an area (#6933)
  • Prefer aerialway=station instead of aerialway=yes for aerialway stations (#6994)
  • Remove deprecation of crossing=zebra (#6962)
  • Remove deprecation of amenity=social_club and leisure=social_club (#6252)
  • Deprecate agrarian=agrcultural_machinry misspelling (#7053)
  • Deprecate company=consulting, office=consultancy, office=consultant, shop=consulting
  • Deprecate type=audio, type=video, type=caldera, type=extinct, type=scoria, type=shield, type=strato, type=extinct
  • Deprecate amenity=research_institution, barrier=railing, craft=glass, man_made=gas_well, man_made=oil_well, man_made=village_pump, power=marker

πŸ› Bugfixes

  • Fix issue with rotating multiple points together (#6977, #6979, thanks @hackily)
  • Fix various instances where issue fixes might not get properly updated (#6588, #7037)
  • Fix unexpected label offsets in Firefox 70 (#7044)
  • Don't move area=yes to nodes when using the Extract operation on areas (#7057)
  • Fix issue where the fills of unclosed multipolygon parts would not render entirely (#2945)
  • Prevent background tiles from appearing larger than expected (#7070)
  • Fix issue where additional fields would disappear immediately upon clearing their value (#6580)
  • Fix issue where adding a raw tag after deleting several would insert the blank row at the wrong index (#7087)
  • Fix issue where OpenStreetMap API error message would persist despite the download of new data (#6650)
  • Replace use of unsupported CSS property flagged by the OpenStreetMap website (#7091)
  • Fix issue where the selected Mapillary detection outline would not render in some browsers (#6804)
  • Fix issue where boundary relation members would not render correctly if they were also multipolygons members (#6787)
  • Fix issue where the Administrative Boundary preset was not properly overriding the Boundary preset (#7118)
  • Fix regression where the relation suggestion list could overflow the inspector (#7115)
  • Fix issue where the Unsquare Corners degree input could be too narrow in some browsers (#7126, thanks @iriman)
  • Correct vertical centering of checkmark fields

🌏 Localization

  • Differentiate the "wireframe mode" and "highlight changes" hotkeys in the German localization (#6972, thanks @manfredbrandl)
  • Improve Chinese address field (#7075, thanks @koaber)
  • Add Bolivia-specific address and phone number formats (#7147, thanks @51114u9)
  • Add the Occitan language to the Multilingual Name field (#7156)

βŒ› Performance

  • Determine locations' country codes without calling out to a geocoding server (#6941)
  • Reduce rendering lag considerably when many features are selected at once (#3571)

πŸŽ“ Walkthrough / Help

  • Update links in the README to avoid http-to-https redirects (#6984, thanks @mbrickn)
  • Add the I hotkey to the Keyboard Shortcuts list (#6997)

πŸš€ Presets

  • Add Notice Board, Poster Box, and Advertising Totem presets (#6965, thanks @hikemaniac)
  • Add Kiddie Ride, Log Flume, and Swing Carousel presets (#7039, thanks @hikemaniac)
  • Add Spice Shop preset (#7031, thanks @scaidermern)
  • Add Giant Chess Board preset (#7059, thanks @ToastHawaii)
  • Add Marker, Utility Marker, and Power Marker presets (#6978)
  • Add Access Aisle preset and style (#7083)
  • Add Research Institute preset and style (#7078)
  • Add Advanced Stop Line preset (#7014)
  • Add Lane Connectivity relation preset (#7105)
  • Add Water Tap preset (#7066)
  • Add Rail Yard preset (#7119)
  • Add unsearchable Disused Railway Feature preset (#7119)
  • Add Recently Demolished Building preset and render them as areas (#7098)
  • Add Recreational Network Node preset for Belgium, Germany, Luxembourg, and The Netherlands (#6992)
  • Add presets for new brands: Consultancy Office, Cleaning Service, Camera Equipment Store, Flooring Supply Shop, Pottery Store, Tool Rental
  • Add Fish Pass preset
  • Append "Area" to the names of linear area presets: Bridge, Tunnel, Road, River, Stream, Canal (#7015)
  • Append "Feature" to the names of various generic presets, e.g. "Tourism Feature"
  • Append "Ride" to the names of some attraction presets, e.g "Pirate Ship Ride"
  • Rename "Wood" preset to "Natural Wood"
  • Rename "Car Pooling" and "Car Sharing" presets to "Car Pooling Station" and "Car Sharing Station"
  • Rename "Pottery" craft preset to "Pottery Maker"
  • Correct "Firepit" preset name to "Fire Pit"
  • Correct capitalization of "J-Bar Lift" and "T-Bar Lift" preset names
  • Update icons for Mast, Communication Mast, and Communication Tower (#6985)
  • Update icons for Gate, Kissing Gate, and Cattle Grid (#6814, #6489)
  • Update icon for Park to be different from Tree (#6633)
  • Update icons for Bunker and Military Bunker (#7139)
  • Update icons for presets: diplomatic offices, marked crossings, transit platforms, buoys, Billboard, Jet Bridge, Scrap Yard, Bicycle Parking Garage, Bicycle Lockers, Bicycle Rental, Bicycle Repair Tool Stand, Boat Rental, Car Pooling Station, Car Sharing Station, Parking Lot, Multilevel Parking Garage, Underground Parking, Park & Ride Lot, Lean-To, Picnic Shelter, Transit Shelter, Block, Chain, Height Restrictor, Turnstile, Barn, Stable, Basket Maker, Boar Builder, Handicraft, Pottery, Indoor Corridor, Cycle & Foot Path, Street Lamp, Commemorative Plaque, Fire Pit, Pier, Floating Pier, Minaret, Tunnel Area, Water Tower, Grassland, Grass, Tree Row, Energy Supplier Office, Insurance Office, Slide, Water Slide, Play Structure, Underground Power Cable, Chocolate Store, Lighting Store, Motorcycle Repair Shop, Storage Rental, Art Installation, Sculpture, Statue, Coastline, Boat Store, Boatyard, Cabin, Holiday Cottage, Alpine Hut, Wilderness Hut, Hostel, Blacksmith
  • Add "tree" as a search term for Natural Wood and Managed Forest (#7097)
  • Add "packstation" as a search term for package pickup and dropoff lockers (#7052)
  • Add "pilates" as a search term for Gym / Fitness Center (#7137)
  • Support limiting fields to specific countries (#7085)
  • Add GNIS Feature ID field to various preset for the United States (#7086)
  • Add VAT ID Number field to business presets for countries where VAT numbers are issued (#6880)
  • Add Wikimedia Commons Page field with link to view the page
  • Add Mapillary ID field with link to view the image on the Mapillary website (#7064)
  • Add Internet Access, SMS, and Video Calls fields to the Telephone preset (#7010)
  • Add Tactile Paving field to the Steps preset (#7082, thanks @stragu)
  • Add Reference Code field to Vending Machine presets (#7002)
  • Add Drinks field to the Drink Vending Machine preset
  • Add Drinkable field to various water source presets
  • Add Type field to Fountain preset
  • Add Pump field to Water Well preset
  • Add Utilities field to Utility Pole and Street Cabinet presets
  • Add Brand field to more presets that could have brand tags
  • Rename "Network Type" field for network to "Network Class"
  • Add Network Type field for network:type to Route presets with a network value
  • Rename "Suggested Hashtags" changeset field to just "Hashtags"
  • Only show the Country field on Flagpole features with flag:type=national (#7099)
  • Don't show the Denomination field on features with religion=none (#7135)

@@ -774,6 +789,10 @@ path.fill.tag-power-plant {
path.stroke.tag-natural-wetland {
stroke: rgb(153, 225, 170);
}
path.fill.tag-natural-wetland {
stroke: rgb(153, 225, 170, 0.3);
fill: rgb(153, 225, 170, 0.3);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines are causing a test failure - should they be rgba instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I updated those lines.

@tomhughes tomhughes merged commit cbaf57e into openstreetmap:master Dec 23, 2019
@quincylvania quincylvania deleted the iD-2.17.0 branch December 23, 2019 21:28
path.fill.tag-landuse-orchard,
path.fill.tag-landuse-vineyard {
stroke: rgb(191, 232, 63, 0.3);
fill: rgb(191, 232, 63, 0.3);
Copy link
Collaborator

@mmd-osm mmd-osm Dec 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those two lines also need to be changed from rgb to rgba, as they cause test failures similar to above.

Copy link
Collaborator

@mmd-osm mmd-osm Dec 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. this is already fixed in openstreetmap/iD@acfd1af, but I don't seem to find the fix for natural-wetland upstream (https://github.com/openstreetmap/iD/blob/master/css/25_areas.css#L197-L198). Somehow those two fixes are now a bit mixed up between repos. πŸ€·β€β™‚οΈ

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmd-osm Okay thanks, I just fixed this on that branch too.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks! Will you create another PR for this repo that fixes vineyards?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhhh I wasn't reading carefully and didn't realize there were two separate issues here πŸ˜‚

Will fix now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants