Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to resolve no-tag warning by deleting feature #6588

Closed
1ec5 opened this issue Jun 29, 2019 · 3 comments
Closed

Unable to resolve no-tag warning by deleting feature #6588

1ec5 opened this issue Jun 29, 2019 · 3 comments
Assignees
Labels
usability An issue with ease-of-use or design validation An issue with the validation or Q/A code
Milestone

Comments

@1ec5
Copy link
Collaborator

1ec5 commented Jun 29, 2019

Touching this way triggers an error about a feature with no tags. The error comes with an option to “Delete this feature”, but clicking it does nothing, presumably because I’m zoomed in to z20 and can’t see enough of the feature to delete it. Either I should be allowed to delete the feature, or the option should be disabled with some sort of note explaining why.

@BjornRasmussen
Copy link
Contributor

The old behavior was that the way would be deleted just like that, and up to hundreds of nodes outside of the downloaded area would get deleted. This was very bad, so @quincylvania changed it to the new behavior.
I think that a note explaining why the object couldn't be deleted would be a nice improvement.

@quincylvania quincylvania added the usability An issue with ease-of-use or design label Aug 21, 2019
@quincylvania quincylvania added the validation An issue with the validation or Q/A code label Oct 4, 2019
@quincylvania quincylvania self-assigned this Nov 12, 2019
@quincylvania quincylvania added this to the 2.16.1 milestone Nov 12, 2019
@quincylvania
Copy link
Collaborator

Okay, now the deletion fix will be enabled or disabled based on the circumstances when the feature is selected, not when the issue was created. If it's disabled there's a tooltip explaining why.

@1ec5
Copy link
Collaborator Author

1ec5 commented Nov 13, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability An issue with ease-of-use or design validation An issue with the validation or Q/A code
Projects
None yet
Development

No branches or pull requests

3 participants