Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indicate route membership with shadow #659

Open
jfirebaugh opened this issue Feb 6, 2013 · 5 comments
Open

indicate route membership with shadow #659

jfirebaugh opened this issue Feb 6, 2013 · 5 comments
Labels
map-renderer An issue with how things are rendered in the map usability An issue with ease-of-use or design

Comments

@jfirebaugh
Copy link
Member

P2 does this:

image

@samanpwbb what do you think? Useful?

@bhousel bhousel added considering Not Actionable - still considering if this is something we want and removed design labels Nov 1, 2016
@NopMap
Copy link
Contributor

NopMap commented Mar 3, 2018

I think there is an important feature missing here.

Potlatch2 is capable of highlighting ways which are members of routes on the map (without selecting anything). This is very helpful to see where route relations are "hidden". It is also possible to distinguish different types of route relations by different color highlighting.

It is probably necessary to switch the highlighting of different types of relations on and off in the sidebar, similar to the "Map Features" checkboxes. Most users will be focusing on one type of relations, e.g. when I am mapping hiking routes, I am not interested in seeing turn restrictions or public transportation.
The default should probably be "off" as new users are ususally not yet familiar with relations and would be confused by the additional highlighting.

@NopMap
Copy link
Contributor

NopMap commented Mar 12, 2018

In my fork I did a basic implementation of the behaviour possible in P2:

  • membership of ways in hiking relations (foot or hiking) is translated in an attribute route-hiking on lines
  • such lines are marked with a white semi-transparent highlight shadow unless selected or hovered upon, then the original selection shadow is used
  • horse routes are similarly highlighted with a bluish shadow
    This makes it easy to note the presence of hiking relations and follow their run across the map.

You can try it out on www.wanderreitkarte.de. My implementation statically supports two route relations to match the focus of my fork, for the iD master it probably should be user-configurable which routes are of interest.

@bhousel
Copy link
Member

bhousel commented Mar 14, 2018

I'll probably do something stylistically similar to what I just added in #4768 in the Turn Restriction editor.

It's not hard, but we need to render another stroke and add some design elements so that users can easily identify them - either by hovering on relations in the sidebar or when one is selected.

tr_preview

(Going to tag this as a priority item)

@bhousel bhousel added usability An issue with ease-of-use or design priority A top priority issue that has a big impact or matter most to new mappers and removed considering Not Actionable - still considering if this is something we want labels Mar 14, 2018
@NopMap
Copy link
Contributor

NopMap commented Mar 14, 2018

I think there are two sides to this issue

  • showing the associated members of a particular relation when selected or hovering, as shown above
  • always marking all members of all instances of a type of route relation even if nothing is hovering/selected, as shown on my fork. E.g. all foot/hiking route relations. This is very helpful to understand routes.

Do you also plan a statical highlighting of the different route types?

@bhousel
Copy link
Member

bhousel commented Mar 14, 2018

Do you also plan a statical highlighting of the different route types?

Not sure what you mean by this, but probably yes.

@quincylvania quincylvania added the map-renderer An issue with how things are rendered in the map label Jul 3, 2019
@quincylvania quincylvania removed the priority A top priority issue that has a big impact or matter most to new mappers label Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
map-renderer An issue with how things are rendered in the map usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

4 participants