Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Seychelles and Pitcairn Islands #6827

Merged
merged 3 commits into from
Sep 4, 2019
Merged

Conversation

leighghunt
Copy link
Contributor

Adding Seychelles to list of countries driving on the left.

@bhousel
Copy link
Member

bhousel commented Sep 3, 2019

The pacific islands you've added are all outside of the normal [-180,180] bounds for longitudes. Aren't they included in the file already?

Screenshot 2019-09-03 18 48 56

@leighghunt
Copy link
Contributor Author

I can't believe I missed that! - Let me just check all of them and resubmit.

@bhousel
Copy link
Member

bhousel commented Sep 3, 2019

I can't believe I missed that! - Let me just check all of them and resubmit.

sure! (Seychelles looks correct though)

…eline - Pitcairn Islands (Adamstown) still needed adding.
@leighghunt
Copy link
Contributor Author

Hi @bhousel - think I've got it sorted (living in NZ, I really shouldn't get tripped up by the dateline!) - you already had Samoa, Tokelau, Tonga, Niue, Cook Islands, but I've added the Pitcairn Islands, so the only two actual changes are habited Pitcairn Islands, and Seychelles.

Thanks for your patience! Would you believe this all started as I wanted to add Hong Kong mainland to another project!?! :-)

@leighghunt leighghunt changed the title Adding Seychelles Adding Seychelles and Pitcairn Islands Sep 3, 2019
@bhousel
Copy link
Member

bhousel commented Sep 4, 2019

Thanks for your patience! Would you believe this all started as I wanted to add Hong Kong mainland to another project!?! :-)

No worries! I'm glad this data is helpful to your project.. Thanks for the additions 👍

@bhousel bhousel merged commit d6e2b1d into openstreetmap:2.15 Sep 4, 2019
leighghunt added a commit to leighghunt/osrm-backend that referenced this pull request Sep 4, 2019
Completely overwriting with latest version from openstreetmap/iD#6827, as per @danpat's suggestion.
@quincylvania quincylvania added this to the 2.15.6 milestone Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants