Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlimited scrolling to zoom in past z24 #6851

Closed
boothym opened this issue Sep 13, 2019 · 5 comments
Closed

Unlimited scrolling to zoom in past z24 #6851

boothym opened this issue Sep 13, 2019 · 5 comments
Assignees
Labels
bug A bug - let's fix this! usability An issue with ease-of-use or design
Milestone

Comments

@boothym
Copy link
Contributor

boothym commented Sep 13, 2019

Firefox/Win10. I can zoom in as far as z24 using the + button, and at that point I also cannot use the scroll wheel to zoom in any further.

However at z23 or below I can use the scroll wheel and keep zooming in, basically to an unlimited number as indicated in the address bar.

@quincylvania
Copy link
Collaborator

@boothym Is the issue here that you shouldn't be able to infinitely zoom? Because I'd agree with that… we're not mapping atoms yet 😄

@quincylvania quincylvania added the usability An issue with ease-of-use or design label Sep 16, 2019
@boothym
Copy link
Contributor Author

boothym commented Sep 16, 2019

@quincylvania yes sorry, should've made myself more clear - basically, zooming past z24 shouldn't be allowed. I'm sure I don't remember being able to do it until recently.

@quincylvania quincylvania added the bug A bug - let's fix this! label Sep 16, 2019
@Atrate
Copy link

Atrate commented Sep 17, 2019

I'd say letting the user choose would be a nice idea though. Some inexperienced mappers don't know how to join nodes and you have to zoom way past z24 in JOSM to see that they are separated

@quincylvania
Copy link
Collaborator

I'd say letting the user choose would be a nice idea though. Some inexperienced mappers don't know how to join nodes and you have to zoom way past z24 in JOSM to see that they are separated

I think there are better ways of telling if nodes are connected in iD, like noting if a vertex is grey vs. white or simply dragging one of them. I could see upping the max zoom to 25 or 26 but beyond that I don't think the benefit is worth the hit to usability and dev support.

@boothym
Copy link
Contributor Author

boothym commented Sep 18, 2019

@megaarthur I'm not sure how allowing scrolling past z24 would help enable inexperienced mappers to join nodes? 😕 I doubt people go around zooming into nodes just to see if they are connected - iD turns the node colour from white to grey*, and now also issues warnings for crossing roads/paths etc.

Plus, iD already prevents people from zooming in past z24 by clicking on the zoom in button. My suggestion is to stop people accidentally zooming in too far with their scroll wheel.

*perhaps the node could be changed to a different shape if people don't notice the colour change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

3 participants